Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the color docs to the style guide #507

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

jonrohan
Copy link
Member

This is an update to some of the color docs to use style guide jekyll variables added in https://github.com/github/styleguide/pull/232

@mts
Copy link

mts commented Jun 20, 2018

I was looking into this PR out of curiosity.
I noticed the HTML under the headers Gray, Blue, Yellow, Red, Green, Purple
in colors.md are missing the html highlighting.
Is it worth adjusting that in this PR so that the markdown shows up properly ?

@jonrohan jonrohan changed the title Using styleguide data variables to fill in color values Moving the color docs to the style guide Jun 20, 2018
@jonrohan
Copy link
Member Author

I noticed the HTML under the headers Gray, Blue, Yellow, Red, Green, Purple
in colors.md are missing the html highlighting.
Is it worth adjusting that in this PR so that the markdown shows up properly ?

@mts we write the html there because we need something extra than we can achieve with plain markdown. For showing these color cards, showing the actual markup is less important. https://styleguide.github.com/primer/support/color-system/#color-variables

@mts
Copy link

mts commented Jun 20, 2018

I understand. Thank you.

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@shawnbot shawnbot mentioned this pull request Jun 22, 2018
10 tasks
@jonrohan jonrohan changed the base branch from release-10.6.1 to release-10.7.0 June 25, 2018 20:31
@jonrohan jonrohan mentioned this pull request Jun 25, 2018
19 tasks
@jonrohan jonrohan merged commit d635114 into release-10.7.0 Jun 26, 2018
@jonrohan jonrohan deleted the color-data-variables branch June 26, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants