Added support for negative offset columns with responsive support #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophshep
reviewed
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
shawnbot
reviewed
Jan 24, 2019
shawnbot
reviewed
Jan 24, 2019
…s sass to use loops instead of hardcoded classes
|
@shawnbot I removed a bunch of those classes as we didn't need the full 1-12 spacing range so that list should be different now. Should just cover 1-7 |
|
Okay @trosage, I got this caught up with v12 and a recent fix to the selector diff report script, and this is what I'm seeing now: > .offset-n1
> .offset-n2
> .offset-n3
> .offset-n4
> .offset-n5
> .offset-n6
> .offset-n7
> .offset-sm-n1
> .offset-sm-n2
> .offset-sm-n3
> .offset-sm-n4
> .offset-sm-n5
> .offset-sm-n6
> .offset-sm-n7
> .offset-md-n1
> .offset-md-n2
> .offset-md-n3
> .offset-md-n4
> .offset-md-n5
> .offset-md-n6
> .offset-md-n7
> .offset-lg-n1
> .offset-lg-n2
> .offset-lg-n3
> .offset-lg-n4
> .offset-lg-n5
> .offset-lg-n6
> .offset-lg-n7
> .offset-xl-n1
> .offset-xl-n2
> .offset-xl-n3
> .offset-xl-n4
> .offset-xl-n5
> .offset-xl-n6
> .offset-xl-n7
> .offset-n1
> .offset-n2
> .offset-n3
> .offset-n4
> .offset-n5
> .offset-n6
> .offset-n7
> .offset-sm-n1
> .offset-sm-n2
> .offset-sm-n3
> .offset-sm-n4
> .offset-sm-n5
> .offset-sm-n6
> .offset-sm-n7
> .offset-md-n1
> .offset-md-n2
> .offset-md-n3
> .offset-md-n4
> .offset-md-n5
> .offset-md-n6
> .offset-md-n7
> .offset-lg-n1
> .offset-lg-n2
> .offset-lg-n3
> .offset-lg-n4
> .offset-lg-n5
> .offset-lg-n6
> .offset-lg-n7
> .offset-xl-n1
> .offset-xl-n2
> .offset-xl-n3
> .offset-xl-n4
> .offset-xl-n5
> .offset-xl-n6
> .offset-xl-n7Look good? |
sophshep
approved these changes
Mar 1, 2019
src/marketing/utilities/layout.scss
Outdated
| } | ||
| } | ||
|
|
||
| @each $breakpoint, $variant in $responsive-variants { |
There was a problem hiding this comment.
I assume this is listed twice (L22-L29 = L31-37) accidentally?
This was referenced Dec 19, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for negative offset columns. This feature is utilized for marketing purposes with offset grids. This also includes responsive support.
/cc @primer/ds-core