Release 12.1.0 #699
Merged
Release 12.1.0 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s sass to use loops instead of hardcoded classes
Add missing zero to $marketing-all-spacers
Add x- and y-axis overflow utilities
Remove unused dev dependencies
Added support for negative offset columns with responsive support
shawnbot
commented
Mar 1, 2019
| @@ -41,7 +41,7 @@ As of [Primer v10.10.0](https://github.com/primer/css/releases/v10.10.0), `prime | |||
|
|
|||
| Rather than toggling the `d-none` class in JavaScript, you should toggle the `hidden` property on an element. This means that you won't have to restore any more specific display utility (`d-inline` or `d-flex`, for instance) just to work around the order in which they're listed in the stylesheet. | |||
|
|
|||
| ```js | |||
| ```js dead | |||
There was a problem hiding this comment.
FYI, dead here just means "not live"... I guess inert might be less controversial?
jonrohan
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primer Minor Release
Version: 📦 12.1.0
Approximate release date: 📆 Feb 29, 2019
🚀 Enhancement
0to responsive marketing positioning utilities (top-lg-0, et al) Add missing zero to $marketing-all-spacers #697📝 Documentation
🏠 Internal
script/selector-diff-reportto compare against@primer/css(notprimer!)Ship checklist
CHANGELOG.mdversionfield inpackage.jsonto match the release version/cc @primer/ds-core