Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects and their properties have same color #88

Open
max-programming opened this issue Oct 13, 2020 · 1 comment
Open

Objects and their properties have same color #88

max-programming opened this issue Oct 13, 2020 · 1 comment
Labels
type: syntax Syntax highlighting

Comments

@max-programming
Copy link

max-programming commented Oct 13, 2020 •
edited
Loading

In the GitHub theme, the inbuilt objects and properties have the same color while newly created have different color.
document.something has the same color while testObj.something has a different color.
image

If we compare this with Default Dark+ theme
image

It would be great to differentiate objects with their properties and methods.

❤️ I LOVE THE GITHUB THEME. I JUST CAN'T LEAVE IT. THANKS FOR WORKING ON IT
@max-programming max-programming mentioned this issue Nov 29, 2020
Closed
@max-programming
Copy link
Author

@simurai I fixed this issue and made a PR at #94

@simurai simurai added the type: syntax Syntax highlighting label Jan 6, 2023
archseer added a commit to helix-editor/helix that referenced this issue Jan 19, 2023
@archseer
theme: Make github match github.com more closely
efeec12 
This is a slight divergence from the VSCode theme, but it's more
accurate.

primer/github-vscode-theme#111
primer/github-vscode-theme#88
kirawi pushed a commit to kirawi/helix that referenced this issue Jan 25, 2023
@archseer
theme: Make github match github.com more closely
b9441eb 
This is a slight divergence from the VSCode theme, but it's more
accurate.

primer/github-vscode-theme#111
primer/github-vscode-theme#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: syntax Syntax highlighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fixed a syntax highlight problem max-programming/github-vscode-theme
2 participants
@simurai @max-programming