🐛 Fixed a syntax highlight problem

[max-programming]

I fixed an issue that I was facing with the object.property and object.method(). This PR closes #88

[max-programming]

Before object.method():

After object.method():

---

Before: object.property:

After object.property:

[max-programming]

Let me know if any changes are required

[max-programming]

@simurai Have you reviewed it?

[simurai]

@max-programming thanks for the PR. 🙇

What language is this for? JavaScript? Below a quick test how your example renders on github.com:

person.doSomething()
console.log()

person.name
console.memory

and here a screenshot in this theme:

Hmm.. since the goal of this theme is to stay as close to github.com as possible, I would say that object.method() is already correct. 👍 But object. property could be fixed. But only the property should be blue and the object can remain white.

Does that make sense?

[max-programming]

@simurai I actually mean that everything works fine when we do person.property or person.method(). But the issue persists when we do document.property or document.method(). I mean any built-in object has the issue. But when we create a custom object, that works fine.

[max-programming]

Here, console.log() is the problem but person.doSomething() is fine.

Here, console.memory is the problem but person.name works fine.

Any built-in object has the issue

[max-programming]

@max-programming thanks for the PR. 🙇

What language is this for? JavaScript? Below a quick test how your example renders on github.com:

person.doSomething()
console.log()

person.name
console.memory

and here a screenshot in this theme:

Hmm.. since the goal of this theme is to stay as close to github.com as possible, I would say that object.method() is already correct. 👍 But object. property could be fixed. But only the property should be blue and the object can remain white.

Does that make sense?

Yeah I will try to add the blue color to the person.name

[max-programming]

Also, person.name isn't highlighted on your end because you have not initialized the person variable

[max-programming]

@simurai I Did not know that you updated it. I'll see if I can do something else to match it later.
Closing it

[simurai]

@max-programming I Did not know that you updated it.

Sorry, this PR #98 only changes the colors.. as in make it lighter or darker, but doesn't change the logic. Like what should be blue and what should be red etc. So that can still be improved separately.

[cmario92]

any updates on this?
I just noticed that I opened another issue that is related to this, but with JSON key/value pairs #129.

[simurai]

I just noticed that I opened another issue that is related to this, but with JSON key/value pairs #129.

They might be related, but it could also be that each language needs to be defined separately. We can keep #129 open until we take a closer look.