-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move previews into root and include in gemspec #1404
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
fab4452
to
a14299a
Compare
a14299a
to
8e29027
Compare
I paired on this with @joelhawksley. We've begun including Lookbook in
github/github
. If we include our primer/view_components previews in the gem then we can pull them into the local Lookbook instance. After some debate we also decided to move them out oftest
and into their own top level directory. It felt wrong including test files in the gem and previews really aren't tests. They can be used by tests but they are, themselves, not tests.