Move sample forms out of test folder #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 991e0ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @steves, thanks for taking this on. I don't remember if this is the case for all of them, but I know some of those forms are indeed used in tests. As long as tests are passing though we should be ok. |
camertron
approved these changes
Oct 5, 2022
steves
force-pushed
the
steves-move-forms
branch
from
550c552
to
dbf8208
Compare
steves
force-pushed
the
steves-move-forms
branch
from
dbf8208
to
8b4072b
Compare
jonrohan
approved these changes
Oct 11, 2022
Merged
jonrohan
added a commit
that referenced
this pull request
Oct 11, 2022
* Move sample forms out of test folder * Add nodoc to form samples * Add missing tests for form previews * Create thirty-forks-hope.md Co-authored-by: Jon Rohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1404 preview files were moved out of
testand into their own top level directory. We later discovered that form previews reference form classes that are defined intest/forms. Because they're in thetestfolder they don't get included in the gem and the previews that use them don't work.Because these sample forms are only used in the previews, and not in any tests that I could find, I moved them into
app/forms. This lets us autoload them in the local Lookbook as well as bundle them into the gem for use in ourgithub/githubLookbook instance.