Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actionmenu focus #2138

Closed
wants to merge 3 commits into from
Closed

Fix actionmenu focus #2138

wants to merge 3 commits into from

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Jul 12, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Screenshots

Integration

List the issues that this change affects.

Closes https://github.com/github/primer/issues/2421

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: f5590e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus temporarily deployed to preview July 12, 2023 10:29 — with GitHub Actions Inactive
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Jul 12, 2023
@keithamus keithamus temporarily deployed to github-pages July 12, 2023 10:33 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to preview July 12, 2023 19:58 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to github-pages July 12, 2023 20:03 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to preview July 17, 2023 22:26 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to github-pages July 17, 2023 22:31 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to preview July 20, 2023 13:27 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages July 20, 2023 13:31 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages July 20, 2023 14:56 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to preview July 20, 2023 14:58 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages July 20, 2023 15:02 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to preview July 26, 2023 21:57 — with GitHub Actions Inactive
@keithamus keithamus self-assigned this Aug 21, 2023
@keithamus keithamus temporarily deployed to preview August 22, 2023 17:33 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to preview August 23, 2023 10:37 — with GitHub Actions Inactive
@jonrohan
Copy link
Member

jonrohan commented Oct 6, 2023

Seems like this was fixed with #2260

@jonrohan jonrohan closed this Oct 6, 2023
@jonrohan jonrohan deleted the fix-actionmenu-focus branch October 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants