-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several ActionMenu a11y fixes #2260
Conversation
🦋 Changeset detectedLatest commit: 3d746cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…w_components into action_menu_close_on_focusout
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor makes the changes here a little difficult to follow but considering there are new tests and the existing tests pass, I'll trust that this hasn't regressed any behaviour.
What are you trying to accomplish?
This PR fixes the following
ActionMenu
issues:This PR also contains a significant refactoring of
ActionMenu
's event handling logic and test helpers.Depends on github/clipboard-copy-element#71
Screenshots
Focusing the first item. Notice the focus ring moves to the second item, indicating the first item was previously focused even though the focus ring does not appear.
focus_first_item.mov
Disabled items can be focused but not activated
disabled_items.mov
Menu closes on focus out
focus_out.mov
Integration
No changes necessary in production.
List the issues that this change affects.
Closes https://github.com/github/primer/issues/2661
Closes #2253
Closes https://github.com/github/primer/issues/2421
Risk Assessment
Accessibility
Merge checklist