Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use “×” for dimensions #5502

Merged
merged 2 commits into from
Jan 14, 2022
Merged

docs: Use “×” for dimensions #5502

merged 2 commits into from
Jan 14, 2022

Conversation

Zearin
Copy link
Contributor

@Zearin Zearin commented Dec 12, 2021 •
edited
Loading

Typographically, "x" !== "×". ☻

Changes:
In comments, when referencing pixel dimensions or matrices, use “×” instead of “x”.

This does not include methods like p5.Matrix.prototype.invert3x3, where “x” is part of the API and cannot change. It’s only for “prose”.

PR Checklist

@Zearin
docs: Use “×” for dimensions
c4e99d4 
Much like `'' !== false` and `null !==  undefined`, the typographical equivalent is `"x" !== "×"`. ☻
@Zearin
Copy link
Contributor Author

Zearin commented Jan 2, 2022

ping

lmccart
lmccart reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@lmccart lmccart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note inline

src/color/creating_reading.js Outdated Show resolved Hide resolved
@Zearin
Copy link
Contributor Author

Zearin commented Jan 13, 2022

@lmccart ping 🙂

@limzykenneth limzykenneth merged commit 196d3af into processing:main Jan 14, 2022
@limzykenneth
Copy link
Member

Looks good. Thanks!

@Zearin
Copy link
Contributor Author

Zearin commented Jan 15, 2022

🙏🏽

This was referenced Feb 3, 2022
Merged
Merged
Open
Open
This was referenced Mar 7, 2022
Open
Open
Merged
Open
Open
@renovate renovate bot mentioned this pull request Nov 20, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmccart lmccart lmccart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zearin @limzykenneth @lmccart