Allow texture() to accept p5.Texture argument without throwing a warning. #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferriss
changed the title
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Small changes to the inline docs to allow
texture()andimage()to accept p5.Texture objects as arguments without throwing a warning when the arguments get validated. This PR depends on #5517 sincetexture()&image()in webGL mode callsetUniform()under the hood.We don't currently have any unit tests for
texture(), so I haven't added any new ones, but I could probably try and cook something up if we think it is important here. I like wise didn't see much in the way of tests for drawing images.PR Checklist
npm run lintpasses