Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow settings object for p5.Texture #5557

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

aferriss
Copy link
Contributor

This is a draft pr. See issue #5556 for more information.

PR Checklist

@stalgiag
Copy link
Contributor

I think this okay to add. I understand how it would be needed for libraries or advanced use-cases and it has no negative impact on current use.

@stalgiag
Copy link
Contributor

Part of me wishes there was a little more clarity on the possible properties for a settings object but I am not sure that is needed since anyone who digs into the code enough to find this will likely know what these are already.

@aferriss
Copy link
Contributor Author

Thanks! @stalgiag I'm happy to add a bit more context and documentation about possible properties in that object.

@aferriss aferriss mentioned this pull request Jan 20, 2022
@aferriss aferriss marked this pull request as ready for review January 22, 2022 01:29
@aferriss
Copy link
Contributor Author

@stalgiag Ok, updated the documentation. Let me know what you think!

@stalgiag
Copy link
Contributor

Looks good! Thank you @aferriss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants