Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves issue #5421 #5572

Merged
merged 1 commit into from
Jan 21, 2022
Merged

resolves issue #5421 #5572

merged 1 commit into from
Jan 21, 2022

Conversation

reejuBhattacharya
Copy link
Contributor

Resolves #5421

Changes:
Added a call to the doFill property to change it to true in ambientMaterial.

Screenshots of the change:
Before:
image
image

After:
image

  • npm run lint passes

@reejuBhattacharya
Copy link
Contributor Author

@limzykenneth @stalgiag
Would love it if you would check out my pull request. Great thanks!

@stalgiag
Copy link
Contributor

Hi @reejuBhattacharya thanks for the friendly ping! This looks good to me!

@stalgiag stalgiag merged commit 89bda47 into processing:main Jan 21, 2022
@processing processing deleted a comment from allcontributors bot Jan 21, 2022
@reejuBhattacharya reejuBhattacharya deleted the issue_5421 branch January 21, 2022 18:52
This was referenced Feb 3, 2022
Merged
Merged
Open
Open
This was referenced Mar 7, 2022
Open
Open
Merged
Open
Open
@renovate renovate bot mentioned this pull request Nov 20, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalgiag stalgiag stalgiag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ambientMaterial() requires a call to fill()
2 participants
@reejuBhattacharya @stalgiag