[NCL-8302] Build Finder cannot find signed binaries in Brew #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janinko
requested changes
Nov 20, 2023
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinderUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinderUtils.java
Show resolved
Hide resolved
core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinderUtils.java
Outdated
Show resolved
Hide resolved
…reviews; refactoring to remove some duplicated code; removal of unnecessary cleanup method after the local archives of build zero match was fixed
janinko
approved these changes
Nov 23, 2023
|
@dwalluck Hi David! Are you ok in merging this one? I will probably open some more PRs to fix other issues |
dwalluck
reviewed
Nov 27, 2023
dwalluck
reviewed
Nov 27, 2023
pom.xml
Outdated
There was a problem hiding this comment.
It's possible to leave out this change.
There was a problem hiding this comment.
Last time I did not push it, the CI build complained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this improvement, the aim is to find additional binaries built from source in Koji, running another search over the binaries which were not found using the provided MD5 checksum, by using the SHA256 checksum. This happens when binaries are signed and are not searchable anymore by MD5, but can be found by SHA256.