Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplication across populate_*_view() functions #48

Closed
kevinaboos opened this issue Feb 21, 2024 · 0 comments · Fixed by #53
Closed

Remove code duplication across populate_*_view() functions #48

kevinaboos opened this issue Feb 21, 2024 · 0 comments · Fixed by #53
Assignees
@kevinaboos
Labels
enhancement New feature or request

Comments

@kevinaboos
Copy link
Member

There's a decent amount of code duplication across:

  • fn populate_redacted_message_view()
  • fn populate_membership_change_view()
  • fn populate_profile_change_view()
  • fn populate_other_state_view()

Originally posted by @kevinaboos in #46 (comment)
@kevinaboos kevinaboos self-assigned this Feb 21, 2024
@kevinaboos kevinaboos added the enhancement New feature or request label Feb 21, 2024
kevinaboos added a commit to kevinaboos/robrix that referenced this issue Feb 26, 2024
@kevinaboos
Deduplicate code across functions that populate small state event views
e1d9a63 
Fixes project-robius#48.

This makes code simpler in the timeline drawing logic functions:
* `fn populate_redacted_message_view()`
* `fn populate_membership_change_view()`
* `fn populate_profile_change_view()`
* `fn populate_other_state_view()`
@kevinaboos kevinaboos mentioned this issue Feb 26, 2024
Merged
kevinaboos added a commit that referenced this issue Feb 26, 2024
@kevinaboos
Deduplicate code across functions that populate small state event vie…
b79cb92 
…ws (#53)

Fixes #48.

This makes code simpler in the timeline drawing logic functions:
* `fn populate_redacted_message_view()`
* `fn populate_membership_change_view()`
* `fn populate_profile_change_view()`
* `fn populate_other_state_view()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinaboos kevinaboos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate code across functions that populate small state event views kevinaboos/robrix
1 participant
@kevinaboos