Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache already-drawn timeline items to avoid expensive draw flows #46

Merged

Conversation

kevinaboos
Copy link
Member

@kevinaboos kevinaboos commented Feb 17, 2024

not ready for merge; doesn't even build yet.

working now.

@kevinaboos kevinaboos marked this pull request as draft February 17, 2024 00:21
@kevinaboos kevinaboos changed the title WIP in the midst of working on caching already-drawn timeline items Cache already-drawn timeline items to avoid expensive draw flows Feb 21, 2024
@kevinaboos
Copy link
Member Author

There's a decent amount of code duplication across:

  • fn populate_redacted_message_view()
  • fn populate_membership_change_view()
  • fn populate_profile_change_view()
  • fn populate_other_state_view()

@kevinaboos
Copy link
Member Author

Also, I think if we use the keep_invisible option on the timeline's portal list, we'll need to clear the cache when transitioning to showing a different room's timeline.

@kevinaboos kevinaboos marked this pull request as ready for review February 21, 2024 04:46
@kevinaboos kevinaboos merged commit 6b3a48d into project-robius:main Feb 21, 2024
1 check passed
@kevinaboos kevinaboos deleted the cache_displayed_timeline_items branch February 21, 2024 04:56
@univerz
Copy link

univerz commented Feb 21, 2024

Also, I think if we use the keep_invisible option on the timeline's portal list, we'll need to clear the cache when transitioning to showing a different room's timeline.

and some method to deep clean the portal_list - when I was evaluating the makepad I modified the news_feed example to show the (flattened) tree and change its root if you click on the (reused) ~like button which has an animation. if i clicked on the third item it became the first one after re-rooting and if it has a third child the animation button will continue on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants