Correct policy for OpenStack sec group with no remote_ip_prefix #8026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
nelljerram
force-pushed
the
port-spec-issue
branch
from
e4f3bb7
to
623227b
Compare
Fixes projectcalico#7968 When an OpenStack security group does not specify a remote_ip_prefix - in other words, it applies to traffic from all possible sources - but it does specify ports - in other words, it only applies to those ports, the resulting Calico policy is _missing_ the restriction to the intended ports, and so is accidentally an allow policy for _all_ ports.
nelljerram
force-pushed
the
port-spec-issue
branch
from
6c37866
to
ff96fc8
Compare
Josh-Tigera
approved these changes
Sep 19, 2023
|
The remaining CI issue is tracked at https://tigera.atlassian.net/browse/CORE-9844 |
nelljerram
added a commit
to nelljerram/calico
that referenced
this pull request
Sep 19, 2023
Correct policy for OpenStack sec group with no remote_ip_prefix
nelljerram
added a commit
to nelljerram/calico
that referenced
this pull request
Sep 19, 2023
Correct policy for OpenStack sec group with no remote_ip_prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7968
When an OpenStack security group does not specify a remote_ip_prefix - in other words, it applies to traffic from all possible sources - but it does specify ports - in other words, it only applies to those ports, the resulting Calico policy is missing the restriction to the intended ports, and so is accidentally an allow policy for all ports.
Release Note