OpenStack port spec issue backport to v3.25 #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct policy for OpenStack sec group with no remote_ip_prefix
✅ Deploy Preview for calico-v3-25 canceled.
|
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
marvin-tigera
added
docs-pr-required
In the Ussuri CI (`make -C networking-calico tox-ussuri`), we recently started getting this error
when executing the pip install line for etcd3gw:
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "/code/.tox/py38/src/etcd3gw/setup.py", line 27, in <module>
setuptools.setup(
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/__init__.py", line 103, in setup
return distutils.core.setup(**attrs)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/dist.py", line 1001, in run_command
super().run_command(command)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/command/develop.py", line 34, in run
self.install_for_development()
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/command/develop.py", line 124, in install_for_development
self.process_distribution(None, self.dist, not self.no_deps)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 770, in process_distribution
self.install_egg_scripts(dist)
File "/code/.tox/py38/lib/python3.8/site-packages/setuptools/command/develop.py", line 151, in install_egg_scripts
self.install_wrapper_scripts(dist)
File "/code/.tox/py38/lib/python3.8/site-packages/pbr/packaging.py", line 450, in install_wrapper_scripts
for args in override_get_script_args(dist):
File "/code/.tox/py38/lib/python3.8/site-packages/pbr/packaging.py", line 436, in override_get_script_args
header = easy_install.get_script_header("", executable, is_wininst)
AttributeError: module 'setuptools.command.easy_install' has no attribute 'get_script_header'
I don't understand why, but anyway I realized that we no longer (since updating to v1.0.1) need to
install etcd3gw in this slightly odd way; we can just put `etcd3gw==1.0.1` in the requirements
files. And it turns out that that fixes the problem at that point in the CI setup.
We had a bug in product code that was recently fixed by projectcalico#6979. That bug caused some port statuses to be signalled as "None" when they should not be. Unfortunately we also had this test (test_snapshot) that had been coded to match the bug, i.e. to expect a port status update of "None". The correct behaviour is that the port status should not be changed by this passage of test code. This was missed at the time of the 6979 PR because our UT running had a bug that allowed some tests to fail but still reported success overall.
That happened in commit 9a8a6c9. The failing test was missed at the time because of how test_command was defined in .testr.conf.
|
The devstack test now fails because of https://tigera.atlassian.net/browse/CORE-9844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick #8026 to the release-v3.25 branch.
Plus copy a lot of other recent tweaks and fixes from master that are needed for UT CI to run correctly and successfully.
Release Note