Jupyter_viz: Allow measures to be None #2163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
measures
crashed when it'sNone
(which is the default). The only way to circumvent this is adding[]
, but that's non-ideal and not obvious.This PR fixes that, so that
measures
can actually be the default value ofNone
.This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.