Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter_viz: Allow measures to be None #2163

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Jul 3, 2024

Currently measures crashed when it's None (which is the default). The only way to circumvent this is adding [], but that's non-ideal and not obvious.

This PR fixes that, so that measures can actually be the default value of None.

This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.

Currently measures crashed when it's None (which is the default). The only way to circumvent this is adding [], but that's non-ideal and not obvious.

This PR fixes that, so that measures can actually be the default value of None.

This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.
@EwoutH EwoutH added the bug Release notes label label Jul 3, 2024
@EwoutH EwoutH requested review from rht and tpike3 July 3, 2024 13:22
Copy link

github-actions bot commented Jul 3, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +1.5% [+1.2%, +1.8%] 🔵 +0.6% [+0.3%, +0.8%]
Schelling large 🔵 +1.4% [+0.7%, +2.1%] 🔵 +0.5% [-0.8%, +2.0%]
WolfSheep small 🔵 +0.7% [-0.0%, +1.5%] 🔵 -0.3% [-0.6%, -0.0%]
WolfSheep large 🔵 +0.3% [-0.1%, +0.8%] 🔵 -0.7% [-1.9%, +0.7%]
BoidFlockers small 🔴 +4.4% [+3.6%, +5.2%] 🔵 +2.1% [+1.3%, +2.8%]
BoidFlockers large 🔵 +3.5% [+2.4%, +4.5%] 🔵 +0.5% [+0.0%, +0.9%]

@rht rht merged commit 0868f4b into projectmesa:main Jul 3, 2024
11 of 13 checks passed
@EwoutH EwoutH deleted the jupyter-viz-measures-none-fix branch July 3, 2024 13:49
@EwoutH
Copy link
Member Author

EwoutH commented Jul 3, 2024

Thanks for merging!

vitorfrois pushed a commit to vitorfrois/mesa that referenced this pull request Jul 15, 2024
Currently measures crashed when it's None (which is the default). The only way to circumvent this is adding [], but that's non-ideal and not obvious.

This PR fixes that, so that measures can actually be the default value of None.

This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.
@EwoutH EwoutH added the backport-candidate PRs we might want to backport to an earlier branch label Sep 24, 2024
EwoutH added a commit to EwoutH/mesa that referenced this pull request Sep 24, 2024
Currently measures crashed when it's None (which is the default). The only way to circumvent this is adding [], but that's non-ideal and not obvious.

This PR fixes that, so that measures can actually be the default value of None.

This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate PRs we might want to backport to an earlier branch bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants