Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter_viz: Allow measures to be None #2163

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Jupyter_viz: Allow measures to be None #2163

merged 1 commit into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. Jupyter_viz: Allow measures to be None 

    Currently measures crashed when it's None (which is the default). The only way to circumvent this is adding [], but that's non-ideal and not obvious.

This PR fixes that, so that measures can actually be the default value of None.

This also proves we need to test Jupyter viz in notebooks, not only in console, since both have different code paths.
    @EwoutH
    EwoutH committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f257c5a View commit details
    Browse the repository at this point in the history