fix: handle non integer values for zone serial #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauritz Leifermann <[email protected]>
|
@SuperQ could u take a look at this? |
SuperQ
reviewed
Mar 11, 2021
SuperQ
requested changes
Mar 11, 2021
Signed-off-by: Lauritz Leifermann <[email protected]>
Signed-off-by: Lauritz Leifermann <[email protected]>
|
has this fix been released on a tagged version yet? |
roosemberth
added a commit
to roosemberth/dotfiles
that referenced
this pull request
Jan 11, 2022
I need this: prometheus-community/bind_exporter#97 Signed-off-by: Roosembert Palacios <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #96
Changes zone type from uint64 to string and checks if the unmarshalled string really is of an value, which can be parsed back to an int. If not set it as 0. (Don't really know if its a good idea to do this implicitly, but this error should not occur in the first place.)
Also tried to extend the test to cover this case of bind reporting a '-' in a zone serial