fix: handle non integer values for zone serial

bind/bind.go

@@ -136,7 +136,7 @@ type Counter struct {
 // Counter represents a single zone counter value.
 type ZoneCounter struct {
 	Name   string
-	Serial uint64
+	Serial string
 }
 
 // Gauge represents a single gauge value.

bind/v2/v2.go

@@ -59,7 +59,7 @@ type View struct {
 type Zone struct {
 	Name       string `xml:"name"`
 	Rdataclass string `xml:"rdataclass"`
-	Serial     uint64 `xml:"serial"`
+	Serial     string `xml:"serial"`
 }
 
 type Counter struct {

bind/v3/v3.go

@@ -80,7 +80,7 @@ type Counter struct {
 type ZoneCounter struct {
 	Name       string `xml:"name,attr"`
 	Rdataclass string `xml:"rdataclass,attr"`
-	Serial     uint64 `xml:"serial"`
+	Serial     string `xml:"serial"`
 }
 
 // Client implements bind.Client and can be used to query a BIND v3 API.

bind_exporter.go

@@ -337,9 +337,15 @@ func (c *viewCollector) Collect(ch chan<- prometheus.Metric) {
 
 	for _, v := range c.stats.ZoneViews {
 		for _, z := range v.ZoneData {
-			ch <- prometheus.MustNewConstMetric(
-				zoneSerial, prometheus.CounterValue, float64(z.Serial), v.Name, z.Name,
-			)
+			if suint, err := strconv.ParseUint(z.Serial, 10, 64); err == nil {
+				ch <- prometheus.MustNewConstMetric(
+					zoneSerial, prometheus.CounterValue, float64(suint), v.Name, z.Name,
+				)
+			} else {
+				ch <- prometheus.MustNewConstMetric(
+					zoneSerial, prometheus.CounterValue, float64(0), v.Name, z.Name,
+				)
+			}
 		}
 	}
 }

bind_exporter_test.go

@@ -62,6 +62,7 @@ var (
 		`bind_resolver_query_duration_seconds_bucket{view="_default",le="1.6"} 188409`,
 		`bind_resolver_query_duration_seconds_bucket{view="_default",le="+Inf"} 227755`,
 		`bind_zone_serial{view="_default",zone_name="TEST_ZONE"} 123`,
+		`bind_zone_serial{view="_default",zone_name="FAULT_TEST_ZONE"} 0`,
 	}
 	taskStats = []string{
 		`bind_tasks_running 8`,

fixtures/v2.xml

@@ -12,6 +12,11 @@
               <rdataclass>IN</rdataclass>
               <serial>123</serial>
             </zone>
+            <zone>
+              <name>FAULT_TEST_ZONE</name>
+              <rdataclass>IN</rdataclass>
+              <serial>-</serial>
+            </zone>
             <zone>
               <name>0.in-addr.arpa/IN</name>
               <rdataclass>IN</rdataclass>

fixtures/v3/zones

@@ -8,6 +8,10 @@
           <type>builtin</type>
           <serial>123</serial>
         </zone>
+        <zone name="FAULT_TEST_ZONE" rdataclass="IN">
+          <type>builtin</type>
+          <serial>-</serial>
+        </zone>
       </zones>
     </view>
   </views>