Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "_total" suffix to ADFS and Net counters #667

Merged
merged 2 commits into from
Nov 29, 2020
Merged

Add missing "_total" suffix to ADFS and Net counters #667

merged 2 commits into from
Nov 29, 2020

Conversation

breed808
Copy link
Contributor

This addresses some of the counters mentioned in #659, and should make a future transition to OpenMetrics easier.

@breed808
Fix ADFS collector metric names
e98d6ad 
Prometheus counters should have a '_total' suffix

Signed-off-by: Ben Reedy <[email protected]>
@breed808
Fix network collector metric names
910ceea 
Signed-off-by: Ben Reedy <[email protected]>
@breed808 breed808 requested a review from a team as a code owner November 24, 2020 11:02
carlpett
carlpett approved these changes Nov 29, 2020
View reviewed changes
Copy link
Collaborator

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The net change will likely break a lot of dashboards, so we'll need to remember to point it out clearly in the release notes.

@breed808 breed808 merged commit ec6b721 into prometheus-community:master Nov 29, 2020
@breed808 breed808 deleted the counters branch November 29, 2020 23:21
@aiyengar2 aiyengar2 mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpett carlpett carlpett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breed808 @carlpett