Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump windows_exporter-package and account for breaking changes #1258

Closed
wants to merge 3 commits into from
Closed

Bump windows_exporter-package and account for breaking changes #1258

wants to merge 3 commits into from

Conversation

aiyengar2
Copy link
Contributor

@aiyengar2 aiyengar2 commented Jun 9, 2021 •
edited
Loading

@aiyengar2 aiyengar2 marked this pull request as ready for review June 9, 2021 01:04
@aiyengar2 aiyengar2 requested a review from jiaqiluo June 9, 2021 01:04
@jiaqiluo jiaqiluo self-requested a review June 9, 2021 20:27
jiaqiluo
jiaqiluo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Rebase is needed.

@aiyengar2 aiyengar2 mentioned this pull request Jun 15, 2021
Merged
1 task
@aiyengar2
Copy link
Contributor Author

Close in favor of #1274

@aiyengar2 aiyengar2 closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqiluo jiaqiluo jiaqiluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiyengar2 @jiaqiluo