feat(networkfirewall): add new check networkfirewall_logging_enabled
#5145
+328
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5145 +/- ##
==========================================
- Coverage 89.12% 89.09% -0.03%
==========================================
Files 993 998 +5
Lines 30509 30693 +184
==========================================
+ Hits 27190 27346 +156
- Misses 3319 3347 +28 ☔ View full report in Codecov by Sentry. |
…://github.com/prowler-cloud/prowler into PRWLR-4556-ensure-logging-is-enabled-for-aws-network-firewall
…ws-network-firewall
sergargar
reviewed
Sep 24, 2024
Comment on lines
21
to
23
|
|
||
| print(firewall.logging_configuration) | ||
|
|
There was a problem hiding this comment.
Suggested change
| print(firewall.logging_configuration) |
sergargar
reviewed
Sep 24, 2024
| "Network Firewall - Describe Network Firewalls Logging Configuration..." | ||
| ) | ||
| try: | ||
| for network_firewall in self.network_firewalls: |
sergargar
reviewed
Sep 24, 2024
Comment on lines
25
to
28
| if ( | ||
| configuration.log_type in LogType | ||
| and configuration.log_destination != {} | ||
| ): |
There was a problem hiding this comment.
The logic should be:
The control fails if logging isn't enabled for at least one log type or if the logging destination doesn't exist.
sergargar
reviewed
Sep 24, 2024
| "CheckType": [ | ||
| "Software and Configuration Checks/Industry and Regulatory Standards/NIST 800-53" | ||
| ], | ||
| "ServiceName": "Network Firewall", |
There was a problem hiding this comment.
Suggested change
| "ServiceName": "Network Firewall", | |
| "ServiceName": "networkfirewall", |
sergargar
reviewed
Sep 24, 2024
| "Software and Configuration Checks/Industry and Regulatory Standards/NIST 800-53" | ||
| ], | ||
| "ServiceName": "Network Firewall", | ||
| "SubServiceName": "Logging", |
There was a problem hiding this comment.
Suggested change
| "SubServiceName": "Logging", | |
| "SubServiceName": "", |
sergargar
reviewed
Sep 24, 2024
| "SubServiceName": "Logging", | ||
| "ResourceIdTemplate": "arn:partition:network-firewall::account-id:firewall/firewall-name", | ||
| "Severity": "medium", | ||
| "ResourceType": "AwsNetworkFirewallLoggingConfiguration", |
There was a problem hiding this comment.
Suggested change
| "ResourceType": "AwsNetworkFirewallLoggingConfiguration", | |
| "ResourceType": "AwsNetworkFirewallFirewall", |
…ws-network-firewall
…rewall' of https://github.com/prowler-cloud/prowler into PRWLR-4556-ensure-logging-is-enabled-for-aws-network-firewall
sergargar
reviewed
Oct 2, 2024
...etworkfirewall/networkfirewall_logging_enabled/networkfirewall_logging_enabled.metadata.json
Outdated
Show resolved
Hide resolved
sergargar
approved these changes
Oct 2, 2024
sergargar
deleted the
PRWLR-4556-ensure-logging-is-enabled-for-aws-network-firewall
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The security of our network is vital to protect sensitive data and infrastructure. Without logging enabled on AWS Network Firewall, we lose visibility into network traffic and firewall actions, which can lead to vulnerabilities and compliance issues.
Description
This check fails when logging is not enabled in 1 or more
Network Firewallfirewalls and returns a list of them.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.