Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(organizations): improve AWS Organizations service #5151

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Sep 23, 2024

Context

Improve AWS Organizations service for a better development of future checks.

Description

  • Improve tests.
  • Beautify syntax.
  • Improve checks.
  • Improve Organization Policies structure.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners September 23, 2024 19:46
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (1f43e6e) to head (fdddac2).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...ny_regions/organizations_scp_check_deny_regions.py 73.33% 8 Missing ⚠️
...ws/services/organizations/organizations_service.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5151      +/-   ##
==========================================
- Coverage   89.19%   89.17%   -0.02%     
==========================================
  Files         976      976              
  Lines       29909    29903       -6     
==========================================
- Hits        26676    26666      -10     
- Misses       3233     3237       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCloudSec MrCloudSec merged commit 3951295 into master Sep 24, 2024
9 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4913-improve-aws-organizations-service branch September 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants