Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add new check organizations_opt_out_ai_services_policy #5152

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Sep 23, 2024

Context

By default, AWS may be using your data to train its AI models. This may include data from your AWS CloudTrail logs, AWS Config rules, and AWS GuardDuty findings.

Description

Create a new check organizations_opt_out_ai_services_policy to ensure that AWS Organizations opt-out of AI services policy is enabled, not granting consent for AWS to access the data.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners September 23, 2024 19:52
@MrCloudSec
Copy link
Member Author

DO NOT MERGE until #5151 is merged.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to see the behaviour of this check with a policy with no content? 🙏🏼

Base automatically changed from PRWLR-4913-improve-aws-organizations-service to master September 24, 2024 12:28
@MrCloudSec
Copy link
Member Author

Could you add a test to see the behaviour of this check with a policy with no content? 🙏🏼

Done!

@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 87.32394% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (1f43e6e) to head (fba72ac).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ny_regions/organizations_scp_check_deny_regions.py 73.33% 8 Missing ⚠️
...ws/services/organizations/organizations_service.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5152      +/-   ##
==========================================
- Coverage   89.19%   89.14%   -0.05%     
==========================================
  Files         976      977       +1     
  Lines       29909    29925      +16     
==========================================
+ Hits        26676    26677       +1     
- Misses       3233     3248      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOP 🐐

@MrCloudSec MrCloudSec merged commit f4d8906 into master Sep 24, 2024
9 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4881-create-aws-check-to-opt-out-for-aws-training-its-ai-models branch September 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants