Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): add comprobations before list tags #5249

Merged

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Sep 30, 2024

Context

If Event Subscription does not have ARN not try to list tags.

Description

Added attributes check before listing tags.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners September 30, 2024 16:46
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Sep 30, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (8805230) to head (f742d65).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
- Coverage   89.12%   89.10%   -0.02%     
==========================================
  Files         993      993              
  Lines       30509    30510       +1     
==========================================
- Hits        27190    27187       -3     
- Misses       3319     3323       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 8e4847e into master Sep 30, 2024
10 of 11 checks passed
@sergargar sergargar deleted the PRWLR-4951-fix-rds-list-tags-for-empty-event-subscription branch September 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants