Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): add comprobations before list tags #5249

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix(rds): add comprobations before list tags #5249

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3135f6e
fix(rds): add comprobations before list tags
puchy22 Sep 30, 2024
f203c7f
chore(rds): change hasattr to getattr
puchy22 Sep 30, 2024
013e22b
chore(rds): add default tag value
puchy22 Sep 30, 2024
f742d65
chore: revision
sergargar Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions prowler/providers/aws/services/rds/rds_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,12 @@ def _describe_db_event_subscriptions(self, regional_client):

def _list_tags(self, resource: any):
try:
resource.tags = self.regional_clients[
resource.region
].list_tags_for_resource(ResourceName=resource.arn)["TagList"]

if getattr(resource, "region", "") and getattr(resource, "arn", ""):
resource.tags = (
self.regional_clients[resource.region]
.list_tags_for_resource(ResourceName=resource.arn)
.get("TagList", [])
)
except Exception as error:
logger.error(
f"{resource.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
Expand Down