Skip beacon chain core spec tests until v0.12 changes are complete #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
requested review from
rauljordan,
shayzluf and
prestonvanloon
and removed request for
a team
terencechain
approved these changes
May 21, 2020
terencechain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Test skipping
What does this PR do? Why is it needed?
This PR skips all of the spec tests in beacon-chain/core/ to not pollute buildkite with test failures while we work on the branch. Once #5935 is complete, this will be reverted.
This PR does not add skips to
shared/bls/spectestandshared/params/spectest, please let me know if either of those are needed.