Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Non-Empty Attestation Indices #5949

Merged
merged 8 commits into from
May 22, 2020
Merged

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Makes indexed attestations with empty indices invalid

Which issues(s) does this PR fix?

Part of #5935

Other notes for review

@rauljordan rauljordan requested a review from a team as a code owner May 21, 2020 20:01
@rauljordan rauljordan requested review from shayzluf, prestonvanloon and terencechain and removed request for a team May 21, 2020 20:01
@rauljordan rauljordan self-assigned this May 21, 2020
@nisdas
Copy link
Member

nisdas commented May 22, 2020

All tests break for this, please fix it first @rauljordan
Ignore, its a merge from master

@nisdas nisdas merged commit a3d6534 into v0.12 May 22, 2020
@farazdagi farazdagi deleted the enforce-nonempty-indices branch August 10, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants