Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen Restrictions for Certain P2P Attestation Validation Conditions #5962

Merged
merged 12 commits into from
May 27, 2020

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

This PR includes two important changes required by https://github.com/ethereum/eth2.0-specs/pull/1801/files#diff-2e616bac0161143d97e596d333a60561R279, which specifically:

  • Validate an aggregate attestation as long as the attester's index is in the beacon committee. Previously, we would have a stricter check which would enforce the attester's index is in the attesting indices
  • Change the check for whether an unaggregated attestation is unaggregated to len(attestationutil.AttestingIndices(att.AggregationBits, committee)) != 1. Previously, we would just check if att.AggregationBits.Count() != 1

Which issues(s) does this PR fix?

Part of #5935

@rauljordan rauljordan requested a review from a team as a code owner May 22, 2020 19:30
@rauljordan rauljordan requested review from farazdagi, 0xKiwi and nisdas and removed request for a team May 22, 2020 19:30
@rauljordan rauljordan self-assigned this May 22, 2020
@rauljordan rauljordan added Ready For Review A pull request ready for code review v0.12 labels May 22, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #5962 into v0.12 will increase coverage by 0.02%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##            v0.12    #5962      +/-   ##
==========================================
+ Coverage   59.32%   59.34%   +0.02%     
==========================================
  Files         319      319              
  Lines       27060    27069       +9     
==========================================
+ Hits        16052    16064      +12     
+ Misses       8797     8794       -3     
  Partials     2211     2211              

@rauljordan rauljordan merged commit ef0d1a9 into v0.12 May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the loosen-restrict branch May 27, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants