-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen Restrictions for Certain P2P Attestation Validation Conditions #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
farazdagi,
0xKiwi and
nisdas
and removed request for
a team
May 22, 2020 19:30
rauljordan
commented
May 22, 2020
rauljordan
commented
May 22, 2020
beacon-chain/sync/validate_committee_index_beacon_attestation_test.go
Outdated
Show resolved
Hide resolved
terencechain
approved these changes
May 26, 2020
Codecov Report
@@ Coverage Diff @@
## v0.12 #5962 +/- ##
==========================================
+ Coverage 59.32% 59.34% +0.02%
==========================================
Files 319 319
Lines 27060 27069 +9
==========================================
+ Hits 16052 16064 +12
+ Misses 8797 8794 -3
Partials 2211 2211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR includes two important changes required by https://github.com/ethereum/eth2.0-specs/pull/1801/files#diff-2e616bac0161143d97e596d333a60561R279, which specifically:
len(attestationutil.AttestingIndices(att.AggregationBits, committee)) != 1
. Previously, we would just check ifatt.AggregationBits.Count() != 1
Which issues(s) does this PR fix?
Part of #5935