Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur module producing a black 'border' at the top and bottom #260

Closed
ccpandhare opened this issue May 21, 2018 · 5 comments · Fixed by #1038
Closed

Blur module producing a black 'border' at the top and bottom #260

ccpandhare opened this issue May 21, 2018 · 5 comments · Fixed by #1038
Assignees
Labels

Comments

@ccpandhare
Copy link
Collaborator

Example Image

Example Image

Example Image Blurred

Example Image Blurred

Is this the intended behaviour of the algorithm or is this a bug?

@jywarren jywarren added the bug label May 21, 2018
@jywarren
Copy link
Member

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #177 (Add a Gaussian Blur module), #108 (Math Module), #112 (Scale module), #5 (image cropping module), and #69 (Create Histogram Module).

@tech4GT
Copy link
Member

tech4GT commented May 21, 2018

@ryzokuken No this is not. I think the image is not being processed to the edges...maybe the loop stops 1 pixel early... I'll look into this😄

@harshkhandeparkar
Copy link
Member

This actually uses another module ndarray-gaussian-blur in this. This is not an original module. This is probably a problem with that npm package. Maybe a version bump will fix this?

@jywarren
Copy link
Member

jywarren commented Mar 18, 2019 via email

@harshkhandeparkar
Copy link
Member

I'll handle this in gpu.js PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants