Create Histogram Module

[ccpandhare]

Also, don't you think that the steps after histogram should use the output from the step BEFORE histogram?
It doesn't quite make sense to apply a module on the "histogram" output.
So what we can do is, the histogram module shows the histogram of the image but passes on ITS INPUT as its output to OTHER modules.

Similarly for the QR Code module?

[jywarren]

Yeah, perhaps we should wait on this a bit. It seems almost like a use case external to image-sequencer, as useful as it is.

[ccpandhare]

You did talk about "Terminating Modules" long ago in #13, I think that can actually be made a thing!
Like we can provide histograms for any image in a sequence, when demanded by the user!
A histogram in the middle of a sequence doesn't make much sense, but one as an on-demand side chain does!

load-image ──> module-1 ──> module-2 ──> module-3
                  │                         │
              histogram                 histogram

[jywarren]

+1

…

On Wed, Jul 26, 2017 at 10:38 PM, Chinmay Pandhare ***@***.*** > wrote: You did talk about "Terminating Modules" long ago in #13 <#13>, I think that can actually be made a thing! Like we can provide histograms for any image in a sequence, when demanded by the user! A histogram in the middle of a sequence doesn't make much sense, but one as an on-demand side chain does! load-image ──> module-1 ──> module-2 ──> module-3 │ │ histogram histogram — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ0dlLn6yzOG4YT9ppNY1gqPlHPNbks5sR6O_gaJpZM4OgFVB> .

[ccpandhare]

We shouldn't use the Plotly one right?
As far as I remember it was slow (#13)

[tech4GT]

@jywarren i was reading up on this and I think I can make this work! I was thinking maybe we can overlay the histogram on the bottom of the image itself, what say?
So histogram can be a meta module which calculates the histogram and overlays it onto the image.

[jywarren]

Cool!

…

On Sat, Sep 29, 2018, 1:35 AM Varun Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> i was reading up on this and I think I can make this work! I was thinking maybe we can overlay the histogram on the bottom of the image itself, what say? So histogram can be a meta module which calculates the histogram and overlays it onto the image. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJxb9nQxEanLbtx0JEswEg_J0TPS7ks5ufyKrgaJpZM4OgFVB> .

[jywarren]

Maybe we can set where the overlay goes?

…

On Sat, Sep 29, 2018, 7:30 AM Jeffrey Warren ***@***.***> wrote: Cool! On Sat, Sep 29, 2018, 1:35 AM Varun Gupta ***@***.***> wrote: > @jywarren <https://github.com/jywarren> i was reading up on this and I > think I can make this work! I was thinking maybe we can overlay the > histogram on the bottom of the image itself, what say? > So histogram can be a meta module which calculates the histogram and > overlays it onto the image. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#69 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABfJxb9nQxEanLbtx0JEswEg_J0TPS7ks5ufyKrgaJpZM4OgFVB> > . >

[tech4GT]

@jywarren please have a look at #354 I have made a basic module for this there.
One thing I can't decide on is whether to make this a meta-module or to include the overlay code in histogram module only, what do you think @jywarren ?

[tech4GT]

I guess we can do something having a module which generates the histogram and then have a separate meta-module histogram-overlay

[jywarren]

👍🏽 good thinking!

…

On Sat, Sep 29, 2018, 7:34 AM Varun Gupta ***@***.***> wrote: I guess we can do something having a module which generates the histogram and then have a separate meta-module histogram-overlay — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8TlXayJ8IS6Zz98wROoQVU5JaVvks5uf3bbgaJpZM4OgFVB> .

[tech4GT]

Closing this one now! 🎉

[jywarren]

🙌

…

On Sat, Oct 13, 2018, 11:58 PM Varun Gupta ***@***.***> wrote: Closing this one now! 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4VznO5SLHnpVy6CwJ4RL3uQoZ4mks5ukg1sgaJpZM4OgFVB> .