-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x and y inputs to Resize module #464
Comments
This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself! |
1 similar comment
@jywarren can I resolve this one? |
haha - one at a time i guess but we'd love your help on all these :-)
…On Wed, Dec 5, 2018 at 10:47 AM Vibhor Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> can I resolve this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#464 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ55vRn8zmIJxYauA8rVhQWz7NOaAks5u1-pkgaJpZM4YYllw>
.
|
Yes, sure! |
Is this resolved yet? Is anyone already working on this? |
Yup, I'm working on this! |
Ok. NP. |
Hi, @VibhorCodecianGupta are you working on this issue? Can I work on this issue? |
Hey Mridul I think let's keep it as first timers only! Thanks :) |
@Divy123 @aashna27 @harshkhandeparkar @MargaretAN9 would anyone like to convert this into an FTO? |
Yeah i ll do that by tomorrow.
…On Thu, Aug 15, 2019, 10:12 PM Jeffrey Warren ***@***.***> wrote:
@Divy123 <https://github.com/Divy123> @aashna27
<https://github.com/aashna27> @harshkhandeparkar
<https://github.com/HarshKhandeparkar> @MargaretAN9
<https://github.com/MargaretAN9> would anyone like to convert this into
an FTO?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#464?email_source=notifications&email_token=AGKQ7SEPHDUTUR3CP244NPLQEWBQLA5CNFSM4GDCLFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MKYMQ#issuecomment-521710642>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGKQ7SBDZYWE33IKV6D2BHDQEWBQLANCNFSM4GDCLFYA>
.
|
awesome! The existing PR is a great starting point!
…On Thu, Aug 15, 2019 at 12:56 PM aashna27 ***@***.***> wrote:
Yeah i ll do that by tomorrow.
On Thu, Aug 15, 2019, 10:12 PM Jeffrey Warren ***@***.***>
wrote:
> @Divy123 <https://github.com/Divy123> @aashna27
> <https://github.com/aashna27> @harshkhandeparkar
> <https://github.com/HarshKhandeparkar> @MargaretAN9
> <https://github.com/MargaretAN9> would anyone like to convert this into
> an FTO?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#464?email_source=notifications&email_token=AGKQ7SEPHDUTUR3CP244NPLQEWBQLA5CNFSM4GDCLFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MKYMQ#issuecomment-521710642
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AGKQ7SBDZYWE33IKV6D2BHDQEWBQLANCNFSM4GDCLFYA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#464?email_source=notifications&email_token=AAAF6J4MN4UOBDHCNFTQYQTQEWDAXA5CNFSM4GDCLFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ML2BY#issuecomment-521714951>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J4UVZ36HXJRA7YDZ4DQEWDAXANCNFSM4GDCLFYA>
.
|
We have a great new Resize module by @KusioDev!
Try it here: http://sequencer.publiclab.org/examples/#steps=resize{resize:25%25}
It's super. Let's expand on it by allowing resize to be done either with locked aspect ratio (the current, where both x and y are scaled the same) or separately by x and y:
See the resize code here: https://github.com/publiclab/image-sequencer/tree/main/src/modules/Resize/
The text was updated successfully, but these errors were encountered: