Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x and y inputs to Resize module #464

Open
jywarren opened this issue Nov 11, 2018 · 15 comments
Open

Add x and y inputs to Resize module #464

jywarren opened this issue Nov 11, 2018 · 15 comments

Comments

@jywarren
Copy link
Member

jywarren commented Nov 11, 2018

We have a great new Resize module by @KusioDev!

Try it here: http://sequencer.publiclab.org/examples/#steps=resize{resize:25%25}

It's super. Let's expand on it by allowing resize to be done either with locked aspect ratio (the current, where both x and y are scaled the same) or separately by x and y:

image

See the resize code here: https://github.com/publiclab/image-sequencer/tree/main/src/modules/Resize/

@gitmate gitmate bot added the module New Module idea label Nov 11, 2018
@jywarren
Copy link
Member Author

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!


@gitmate
Copy link

gitmate bot commented Nov 11, 2018

GitMate.io thinks possibly related issues are #435 (Resize/scale module), #205 (add "drag to crop" UI feature to Crop module), #138 (Add a Dithering module), #157 (Add a Contrast module), and #233 (Add an "import image" module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 11, 2018

GitMate.io thinks possibly related issues are #435 (Resize/scale module), #205 (add "drag to crop" UI feature to Crop module), #138 (Add a Dithering module), #157 (Add a Contrast module), and #233 (Add an "import image" module).

@vibhorgupta-gh
Copy link

@jywarren can I resolve this one?

@jywarren
Copy link
Member Author

jywarren commented Dec 5, 2018 via email

@vibhorgupta-gh
Copy link

Yes, sure!

@harshkhandeparkar
Copy link
Member

Is this resolved yet? Is anyone already working on this?

@vibhorgupta-gh
Copy link

Yup, I'm working on this!

@harshkhandeparkar
Copy link
Member

Ok. NP.

@Mridul97
Copy link

Mridul97 commented Dec 27, 2018

Hi, @VibhorCodecianGupta are you working on this issue? Can I work on this issue?

@tech4GT
Copy link
Member

tech4GT commented Dec 28, 2018

Hey Mridul I think let's keep it as first timers only! Thanks :)

@vibhorgupta-gh
Copy link

@tech4GT #571

@jywarren
Copy link
Member Author

@Divy123 @aashna27 @harshkhandeparkar @MargaretAN9 would anyone like to convert this into an FTO?

@aashna27
Copy link

aashna27 commented Aug 15, 2019 via email

@jywarren
Copy link
Member Author

jywarren commented Aug 15, 2019 via email

@harshkhandeparkar harshkhandeparkar removed the has-pull-request Issues which have a PR open label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants