added gif feature #360
added gif feature #360
Conversation
|
|
|
@rockstar777 2 things
|
|
But great work! Thanks for your pr!😄 |
|
Updates made that are asked for... |
|
@rockstar777 improve gif button |
|
@avsingh999 Can you please explain did'nt get what to improve more. Is that color or shape or margin or something else? |
|
margin |
|
@rockstar777 can you post gif of this pr where I can understand what have you done |
|
|
|
@rockstar777 Place Download as a gif button along with download and add step It would be better |
|
it would look better but we are considering gif for all images of each step. |
|
Yes, i think we're eventually going to have to have a whole region just for
adding new steps, maybe with preview thumbnails for different steps. So it
may eventually need more space in that area.
And then a separate "downloading" area with all the download options. What
do you think? Thanks!!!
…On Mon, Oct 1, 2018 at 11:00 AM puneet bindal ***@***.***> wrote:
it would look better but we are considering gif for all images of each
step.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#360 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_fMRkbbjt1QC4kWywFMY8eQjbYtks5ugi4EgaJpZM4XBJzg>
.
|
|
@jywarren agree with that one area for step section and one for download option could look better. |
|
@jywarren So what about this? |
|
I love it! And the gif itself - perhaps we center it at the bottom with
`padding: 50px` ?
Is it a bit squished? Maybe we need to set the dimensions?
…On Mon, Oct 1, 2018 at 4:28 PM puneet bindal ***@***.***> wrote:
[image: screenshot 27]
<https://user-images.githubusercontent.com/26599651/46313818-7cb22600-c5e6-11e8-980a-e32845355eb7.png>
@jywarren <https://github.com/jywarren> So what about this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#360 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ4U4ndbvm8F5REK6e4xwZqzeqnXOks5ugnrUgaJpZM4XBJzg>
.
|
|
No not at all, we just has to create some extra attributes like id for gif element. |
|
|
|
ah, i believe you can retrieve the dimensions of the original image via the
sequencer API, unless I'm mistaken -- through the `options` parameter:
https://github.com/publiclab/image-sequencer/blob/5a362f5c9afe19cbf20c7cab942d6e486078ab99/src/modules/Crop/Crop.js#L14-L15
…On Mon, Oct 1, 2018 at 4:55 PM puneet bindal ***@***.***> wrote:
No not at all, we just has to create some extra attributes like id for gif
element.
and for dimension i think 400px wide and 350px could be perfect.
What say @jywarren <https://github.com/jywarren> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#360 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxjhfsoTuX8-YlKTcxUHS4hUBIKTks5ugoEagaJpZM4XBJzg>
.
|
|
that looks lovely! Were you able to get the right dimensions?
…On Mon, Oct 1, 2018 at 5:38 PM puneet bindal ***@***.***> wrote:
[image: screenshot from 2018-10-01 14-33-16]
<https://user-images.githubusercontent.com/26599651/46317272-21853100-c5f0-11e8-86b1-f6d8e30ac289.png>
@jywarren <https://github.com/jywarren> how about this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#360 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1O06oEdm-n13_Jahyf7S1VeqXoRks5ugosjgaJpZM4XBJzg>
.
|
|
let me try |
|
@jywarren @rockstar777 I was thinking of downloading the gif and not displaying it in the page, do you think this will be better? Also @rockstar777 looks like we have to rebase here. |
|
@rockstar777 please solve conflicts, Thank you |
|
Hmm, @rockstar777 maybe we can do like a small eye logo which displays the preview but I don't think that's required since the preview is the sequence itself, we are just exporting it as gif. Nothing new is being generated. |
|
@tech4GT I think @rockstar777 is right if we want to download as gif user will preview for that gif before download if wants any changes in that gif he/she can change |
|
@rockstar777 I think you misunderstood me there, the button name was fine, I meant clicking on the gif should download it, like we do for the step images in the sequence. Thanks! |
Signed-off-by: Varun Gupta <[email protected]>
Signed-off-by: Varun Gupta <[email protected]>
|
ok got it @tech4GT but that funtion already works in this PR.:smile: |
|
Great work @rockstar777 I think we are ready to merge here, but first a couple of pointers for you
|
|
thanks @tech4GT for your guidance, I was actually facing problem in resolving conflicts. |
…clab#393) * Fixes alignment of message in Add step box * fixes css info id * updates class selector in demo * Spacing changes
ghost
assigned
|
Almost done here, the checks were not appearing properly so I restarted them. Great teamwork folks. Thanks to everyone!! |
|
Ah, I see! This needs a quick rebasing... Are you able to give it a try? If so I can merge as soon as you're done, or I can help out. Sorry to introduce the conflicts by merging another PR; sometimes this happens!!! |
Signed-off-by: Ankit Singla <[email protected]>
* add histogram module Signed-off-by: tech4GT <[email protected]> * add option to drop gradient Signed-off-by: Varun Gupta <[email protected]> * fix bug Signed-off-by: Varun Gupta <[email protected]>
|
Okay no worries I'll rebase this! |
Signed-off-by: Varun Gupta <[email protected]>
|
Thanks @tech4GT but also please guide me through some tutorial about rebasing |
|
Awesome, ready to merge then? Here's some resources on rebasing!!! |
|
Fantastic!!! I will publish this soon but would you like to open a pull request to increment or "bump" the version number in accordance w http://semver.org? This is essentially a new feature so I believe itd be a 0.x.0 type change. Does this make sense? |
Fixed #344