correctly regulates the behaviour of all links (fixes #386) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Singla <[email protected]>
tech4GT
reviewed
Oct 7, 2018
There was a problem hiding this comment.
@Ankit-Singla This is looking good! Please attach a gif demonstrating the process, you can use GIPHY Capture utility to do so. Also where does the read more link point to now?
Thanks!
|
The read more link now points to the intended target document, as specified corresponding to the description key in info.json of that specific module. GIF for earlier behaviour : GIF after update : |
tech4GT
approved these changes
Oct 7, 2018
|
Awesome!!! Great catch and thanks!!! |
jywarren
pushed a commit
that referenced
this pull request
Oct 10, 2018
* added gif feature * increased frame duration n changed gif btn name * removed inline css * improved ui * #363 Add placeholder option to input (#370) * Add placeholder option to input , change type of brightness input to number Changes to be committed: modified: examples/lib/defaultHtmlStepUi.js modified: src/modules/Brightness/info.json * change 0% to 0 in brightness placeholder * Add gamma module (#374) * Add gamma module * update description * Add matrix math module (#358) * Add matrix math module * add info.json file * correct format of module * Add a constant factor input field * clone the pixels array * change default values * add extra information on convolution module (#381) * adds default values to input fields for all module steps ( fixes #382 ) (#384) * added default values to input fields for all module steps * merged Signed-off-by: Ankit Singla <[email protected]> * Accept type images in input field #364 (#366) * gif button name changed * fixes #383 (#396) Signed-off-by: Varun Gupta <[email protected]> * fix (#387) Signed-off-by: Varun Gupta <[email protected]> * updated * Issue #392 Fixes alignment of message in Add step box (#393) * Fixes alignment of message in Add step box * fixes css info id * updates class selector in demo * Spacing changes * correctly regulates the behaviour of all links (#397) Signed-off-by: Ankit Singla <[email protected]> * enables Save button for an action if any of its input fields gain focus (#394) * Updated index.html (#379) * add histogram module (#354) * add histogram module Signed-off-by: tech4GT <[email protected]> * add option to drop gradient Signed-off-by: Varun Gupta <[email protected]> * fix bug Signed-off-by: Varun Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankit Singla [email protected]
Fixes the issue where clicking the Read more in the description of some modules led to image being downloaded.
While working on this, I also found that in the modules this was happening (Convolution, NDVI etc.), clicking on the image didn't result in download of the image, since the download was mapped to the Read more link instead.
I found another issue where clicking a link in the description didn't result in it opening in a new tab, this PR also fixes that.
So, overall this PR regulates the behaviour of all links more appropriately.
@jywarren @tech4GT