Add a 'Start a new sequence' button

[Mridul97]

Fixes #496

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[jywarren]

Hi, @Mridul97 is this almost the same as #581 by @aashna27 ? If so, perhaps you two could collab or review each others' solutions and submit a joint one?

Perhaps it should open in a new window in case people lose their work, too?

[Mridul97]

Oh! Yes it seems quite similar, both are opening a new page with no steps but in this case we are opening it in a new tab. So people would not lose their work.

What would be better to click on the button "Start a new sequence" to open a new page or clicking on the header or both, depending on that maybe we can merge one or both PRs?

I think having a seperate button makes it more clear to the user. Thanks! 😄

[aashna27]

@mridul but why add buttons unnecessarily when it can be done with the header, also most websites have this thing that you click on the logo or the name and it takes you to the home page. What say? 🤔

[jywarren]

I think both are different ways of thinking of similar functionality - one reason to have a button might be that people may not know how to "clear" the sequence and start a new one, and it does seem like in a web app of this complexity, "starting a new sequence" may not seem obviously the way. I'm also concerned about people losing their work, so what do you think about having both a minimal button like [+ New sequence] AND the header do this, but both open a new window? Thanks for thinking through this carefully!

…

On Thu, Jan 3, 2019 at 7:59 AM aashna27 ***@***.***> wrote: @mridul <https://github.com/mridul> but why add buttons unnecessarily when it can be done with the header, also most websites have this thing that you click on the logo or the name and it takes you to the home page. What say? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3ujo5EcRdUyeosnYIRowEwEPL3Hks5u_f6LgaJpZM4ZmAL3> .

[harshkhandeparkar]

If the header restarts the sequence then there is a high chance that the user may click the header by mistake and loose the work. Instead i think the header should open a new page with a new sequence and the foooter should have a button which can clear the current sequence but with a conformation.

[aashna27]

If the header restarts the sequence then there is a high chance that the user may click the header by mistake and loose the work. Instead i think the header should open a new page with a new sequence and the foooter should have a button which can clear the current sequence but with a conformation.

yess seems perfect !!

[jywarren]

super!

…

On Thu, Jan 3, 2019 at 12:35 PM aashna27 ***@***.***> wrote: If the header restarts the sequence then there is a high chance that the user may click the header by mistake and loose the work. Instead i think the header should open a new page with a new sequence and the foooter should have a button which can clear the current sequence but with a conformation. yess seems perfect !! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ5DvPSNostMAohMTA1i-0r_Bh8l5ks5u_j89gaJpZM4ZmAL3> .

[Mridul97]

@jywarren Please have a look!

[harshkhandeparkar]

@Mridul97 I think the button should confirm if the user wants to reset the sequence. The user may click on that button instead of clicking on download png and may loose progress.

[Mridul97]

@harshkhandeparkar Nice! I will add a confirmation option. Thanks!

[harshkhandeparkar]

Cool that will be awesome 😊

…

On 07-Jan-2019 11:59 PM, "Mridul97" ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> Nice! I will add a confirmation option. Thanks!

[harshkhandeparkar]

@Mridul97 I have a few suggestions

you can shorten the if statement to:

if(r) window.location = "/";

No need to catch the e variable in the function.

Also can you use <button> instead of <input> for uniformity?

[Mridul97]

Done! Here is the new output :

[harshkhandeparkar]

There is still a </a> remaining here @Mridul97.

[harshkhandeparkar]

Looks awesome @Mridul97.

[jywarren]

Awesome! Can we have it be a white button (btn-default, I think?) And say "clear all steps"? Since restart might sound like just rerunning everything.

Thanks!!

[Mridul97]

@jywarren I have made the changes. Please have a look!