-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: UI test script to Travis #791
Conversation
@publiclab/is-reviewers @publiclab/reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov badge from README is missing.
@VibhorCodecianGupta I was working on this issue and following the discussion, you should have asked me if I was already working on it or not. |
@Divy123 Oh! That's totally my fault, I'm really sorry. Didn't mean to at all. I actually did not realise you had claimed this one, I had the wrong impression that you were working on module tests rather than code coverage 😅 |
Very cool! Great work, @VibhorCodecianGupta !!! |
Addresses #740 partially
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/reviewers
and@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!