Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: UI test script to Travis #791

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Conversation

vibhorgupta-gh
Copy link

@vibhorgupta-gh vibhorgupta-gh commented Feb 18, 2019

Addresses #740 partially

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@vibhorgupta-gh
Copy link
Author

@publiclab/is-reviewers @publiclab/reviewers

@vibhorgupta-gh vibhorgupta-gh changed the title Code coverage Add: UI test script to Travis and code coverage Feb 18, 2019
@vibhorgupta-gh vibhorgupta-gh mentioned this pull request Feb 18, 2019
2 tasks
Copy link

@dojutsu-user dojutsu-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov badge from README is missing.

@dojutsu-user
Copy link

@VibhorCodecianGupta
I think @Divy123 was already working on implementing this feature.
I would suggest closing this PR because it was not assigned to you.
Thanks.
cc: @jywarren

@Divy123
Copy link
Member

Divy123 commented Feb 18, 2019

@VibhorCodecianGupta I was working on this issue and following the discussion, you should have asked me if I was already working on it or not.
Since I am working on some other issues as well, it got a bit delayed. In #606 #488 also same thing happenned.
I request you to please close this PR so that a good workflow is maintained.

@vibhorgupta-gh
Copy link
Author

vibhorgupta-gh commented Feb 18, 2019

@Divy123 Oh! That's totally my fault, I'm really sorry. Didn't mean to at all. I actually did not realise you had claimed this one, I had the wrong impression that you were working on module tests rather than code coverage 😅
I'll undo the code coverage stuff, and just leave the ui test part in. Apologies!
You can also take excerpts from my setup here and implement the same thing in your PR. It's all tested. Cheers.
cc: @jywarren

@vibhorgupta-gh
Copy link
Author

This now addresses adding ui tests to travis. @jywarren
@Divy123 you can go ahead and implement codecov, apologies again!

@vibhorgupta-gh vibhorgupta-gh changed the title Add: UI test script to Travis and code coverage Add: UI test script to Travis Feb 20, 2019
@jywarren jywarren merged commit 29b0571 into publiclab:main Feb 21, 2019
@jywarren
Copy link
Member

Very cool! Great work, @VibhorCodecianGupta !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants