White balance module

[jywarren]

I think this could be done with the OpenCV.js module which is under development in #237 -- but for what it's worth, it'd be great to have a white balance module:

https://stackoverflow.com/questions/51372779/color-balance-formula-adding-too-much-white

could help!

We'd love help with this one!

[gitmate]

GitMate.io thinks possibly related issues are #367 (Create Contrast Module), #5 (image cropping module), #157 (Add a Contrast module), #69 (Create Histogram Module), and #119 (Create Histogram Module).

[gitmate]

GitMate.io thinks possibly related issues are #367 (Create Contrast Module), #5 (image cropping module), #157 (Add a Contrast module), #69 (Create Histogram Module), and #119 (Create Histogram Module).

[Divy123]

This issue seems interesting to me. I would like to work on it.

[vibhorgupta-gh]

#585 @jywarren @tech4GT
looking for better algorithms.

EDIT
Found a better algorithm, adjusts the colour balance based on a temperature parameter which is then converted to an equivalent rgb value.
The PR is complete now

@tech4GT

[Divy123]

I am already working on this issue. Please look into some other issue.

[vibhorgupta-gh]

@Divy123 Apologies, Since there was no progress or updates here, I assumed it unclaimed. Will take care from now on. Let's leave it to the reviewer's discretion 😅

[Divy123]

No problem @VibhorCodecianGupta 😄 .

[jywarren]

Ah, no problem - perhaps you could collaborate? One thing I'm interested in is if we could have a "click on a grey area" type interface to choose what is the white point from a given image by clicking on the image. What do you think?

…

On Tue, Jan 1, 2019 at 7:15 AM Slytherin ***@***.***> wrote: No problem @VibhorCodecianGupta <https://github.com/VibhorCodecianGupta> 😄 . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwKqmJSvx-Ouf4bcl-kucBbXnBWxks5u-1E3gaJpZM4Yvdh7> .

[vibhorgupta-gh]

@jywarren Didn't really get the deliverable. Do you mean something like clicking on any point in the given picture, and that returns the nearest white pixel? I'm sure I'm getting this wrong. Is there any example of what you desire?

[jywarren]

Ah, no, i just mean that a common way to determine a white balance is to click on the image on a pixel which you visually deem to be "neutral" colored, and to use that pixel to calculate a white balance correction. Does that make sense?

…

On Tue, Jan 1, 2019 at 11:12 PM Vibhor Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> Didn't really get the deliverable. Do you mean something like clicking on any point in the given picture, and that returns the nearest white pixel? I'm sure I'm getting this wrong. Is there any example of what you desire? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwLXWV0JASeisYLrNf_n4_15uVVmks5u_DGlgaJpZM4Yvdh7> .

[Divy123]

Sure @jywarren . @VibhorCodecianGupta can we collaborate on this?

[vibhorgupta-gh]

@jywarren right, I get you. So what the PR #585 does, is taking input in the form of picture temperature, and accordingly, transform the picture. White balance/colour balance as it is called is applied on the basis of that temperature.
So the addition that you made can be made by accessing the pixel value clicked, and then find the correction based on that. I will have to search for a good algorithm for this purpose, will get on with it. Also, there is an internet issue at my location, I'll post the references I used in making my PR too.

[jywarren]

That sounds great. If you think #585 is ready to go we can merge that and continue work on the follow-up, or we could merge both together?

…

On Wed, Jan 2, 2019 at 5:56 AM Vibhor Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> right, I get you. So what the PR #585 <#585> does, is taking input in the form of picture temperature, and accordingly, transform the picture. White balance/colour balance as it is called is applied on the basis of that temperature. So the addition that you made can be made by accessing the pixel value clicked, and then find the correction based on that. I will have to search for a good algorithm for this purpose, will get on with it. Also, there is an internet issue at my location, I'll post the references I used in making my PR too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ5yYZsCdiOoSPKI83XTHWuqMm2C6ks5u_JAlgaJpZM4Yvdh7> .

[vibhorgupta-gh]

@jywarren that's your discretion, but I'd suggest breaking it into subproblems. Since #585 is in itself complete, it could be merged, and the above-suggested idea can be implemented as a follow-up. Looking for algorithms now. Cheers!

[jywarren]

Great, agreed on small PRs. Super!

…

On Thu, Jan 3, 2019 at 12:37 PM Vibhor Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> that's your discretion, but I'd suggest breaking it into subproblems. Since #585 <#585> is in itself complete, it could be merged, and the above-suggested idea can be implemented as a follow-up. Looking for algorithms now. Cheers! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ17IEAUahu_HycR9ykiVpBAC_vSWks5u_j-ngaJpZM4Yvdh7> .

[harshithpabbati]

Was anyone working in making the actual white balance or can i give it a shot??

[harshkhandeparkar]

Go ahead!

[vibhorgupta-gh]

@harshithpabbati I'm working on this 😅 give me some time, I think I can come up with the module

[harshithpabbati]

Sure carry on with it.

[jywarren]

I just pinged Nirav on this but this will also be really helpful to this module -- ability to click to select a point (to choose the "neutral" point for white balance): #796 Thanks all!

…

On Mon, Mar 4, 2019 at 11:03 AM Harshith pabbati ***@***.***> wrote: Sure carry on with it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4dGIkm56MwU_9AfCXUF2oyaxgFCks5vTUOpgaJpZM4Yvdh7> .