Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the download button #834

Closed
wants to merge 2 commits into from
Closed

Added the download button #834

wants to merge 2 commits into from

Conversation

harshithpabbati
Copy link

Fixes #391

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar
Copy link
Member

Harshith, please refer to this to add the download functionality

https://github.com/publiclab/image-sequencer/blob/main/examples/lib/defaultHtmlStepUi.js#L238-L244

@harshithpabbati
Copy link
Author

Why was that needed as we already have a function to download???
$('#download-btn').click(function() {
$('.step-thumbnail:last()').trigger("click");
return false;
});
I am trying to use #download-btn id to it but i can't do it .

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Mar 5, 2019 via email

@aashna27
Copy link

aashna27 commented Mar 8, 2019

Please provide a screenshot.

@aashna27
Copy link

Hey can the conflicts be resolved here ? and a screenshot be made available because I have to proceed with this for one of my tasks so if you allow I would add the download button along with my task.

@harshithpabbati
Copy link
Author

@aashna27 you can go with it

@aashna27
Copy link

aashna27 commented Jun 5, 2019

Can we close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add download button to download image from a specific module
3 participants