Add download button to download image from a specific module

[Paarmita]

In order to download the image, we need to click on it to do this. But if a button can be made to this, which is a good pattern to follow.

UI for download button can be

Files need to be changed in order to add the button

image-sequencer/examples/lib/defaultHtmlStepUi.js

Line 40 in 2e7e042

<button confirm="Are you sure?" class="remove btn btn btn-default">\

[gitmate]

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #5 (image cropping module), #157 (Add a Contrast module), #27 (add fisheyegl module), #368 (Add a Gamma module), and #138 (Add a Dithering module).

[gitmate]

GitMate.io thinks the contributors most likely able to help are @jywarren, and @tech4GT.

Possibly related issues are #5 (image cropping module), #157 (Add a Contrast module), #27 (add fisheyegl module), #368 (Add a Gamma module), and #138 (Add a Dithering module).

[tech4GT]

@Paarmita I think we already have a lot of ways to download stuff, adding one more seems redundant, what do you think?

[Paarmita]

@tech4GT But it would be a great way to do so and removing other like clicking on the image. The button near Add step only downloads the last module image and not other.
And what does save sequence do as it didn't worked in my case?

[tech4GT]

@Paarmita I see, let's keep this one long term then since right now apart from click to download and the download buttons, we are adding a save as gif button and too many buttons sort of give a bad UX. Let's keep this on hold until we figure out exactly how we want to handle the downloads part, I think @Mridul97 is working on some major design changes as well so maybe we can look into this post that.
As for the Save Sequence feature, it encodes the complete sequence and stores it in the browser's localstorage(in a json file in cli), this will then pop up in the dropdown menu of modules, do you get it?

[harshithpabbati]

Is this closed??
If not can I work on this??

[harshkhandeparkar]

@harshithpabbati do you think this button will be helpful? Currently clicking the image downloads it so adding a new button will be kind of redundant.

Another way would be to remove the image click to download functionality

What would you like to do? Do you have any other ideas?

[harshithpabbati]

@harshkhandeparkar It's better to have a download button because everyone don't know that they can download it by clicking on the image..What would you say?? Lets add it and the user uses which he feels convient.

[harshkhandeparkar]

Go ahead.

[harshithpabbati]

Where do I add the download button??

[harshithpabbati]

Is this ok if I add it here??

[harshkhandeparkar]

@harshithpabbati you have to add the button for each step. In the examples/lib/defaultHtmltStepUi.js file linked above in the issue body.

[harshithpabbati]

Even now it changes for each step. It gets the image with most recent change

[harshkhandeparkar]

That's already available in the download as PNG box. This button should be added next to the remove step and add buttons

[harshithpabbati]

oh ok sure i will make the change.

[harshithpabbati]

Is this the thing which you want??

[harshkhandeparkar]

Yes. Looks cool! Please open a PR. We can do the further discussion there

[harshithpabbati]

i didn't made the function.I jst placed it there

[harshithpabbati]

I mean the download button will not work..

[harshkhandeparkar]

Np open a PR.

…

On Sun 17 Feb, 2019, 3:48 PM Harshith pabbati ***@***.*** wrote: i didn't made the function.I jst placed it there — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#391 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhKOn6IwLqg3vPhSfw6tDZuJwuRKV0e8ks5vOSx5gaJpZM4XK7Oa> .

[Divy123]

@Paarmita I see, let's keep this one long term then since right now apart from click to download and the download buttons, we are adding a save as gif button and too many buttons sort of give a bad UX. Let's keep this on hold until we figure out exactly how we want to handle the downloads part, I think @Mridul97 is working on some major design changes as well so maybe we can look into this post that.
As for the Save Sequence feature, it encodes the complete sequence and stores it in the browser's localstorage(in a json file in cli), this will then pop up in the dropdown menu of modules, do you get it?

This discussion has already taken place and I think @harshithpabbati should wait for the response of @tech4GT to proceed further.
We don't want any of your work to get wasted so I request you to please wait until Varun gives a green flag as this might not be a need here.

[harshkhandeparkar]

@Divy123 that discussion is very old. Many changes have taken place since that. The four save buttons have been merged into one. Instead of clicking the image, clicking a button can be better as ot is more obvious. Also the image click can be used for a different thing like getting a larger preview. What do you think?

[Divy123]

@harshkhandeparkar your suggestions are good enough, but following with the discussion I think we should wait for Varun's opinion here.

[harshkhandeparkar]

Ok then. As you say 😊

[harshkhandeparkar]

@jywarren @tech4GT we would like to hear your opinion here.

[meet2410shah]

I also want to solve the issue.

[harshithpabbati]

There's a open pr here.So kindly you can search for other one
Thanks:)

[harshkhandeparkar]

Done