Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert database.yml to previous state #725

Merged
merged 6 commits into from
Jun 27, 2019
Merged

Revert database.yml to previous state #725

merged 6 commits into from
Jun 27, 2019

Conversation

kaustubh-nair
Copy link
Member

@kaustubh-nair kaustubh-nair commented Jun 19, 2019

@codeclimate
Copy link

codeclimate bot commented Jun 19, 2019

Code Climate has analyzed commit d3e7429 and detected 0 issues on this pull request.

View more on Code Climate.

@kaustubh-nair kaustubh-nair changed the title Fix database.yml for test environment for unstable Revert database.yml to previous state Jun 22, 2019
@kaustubh-nair
Copy link
Member Author

I've reverted to exactly the same database.yml that we used to previously use. Why is this failing?!? 😕
@alaxalves Need some help here

@kaustubh-nair
Copy link
Member Author

But surprisingly unstable is working!
https://jenkins.laboratoriopublico.org/job/Mapknitter-Unstable/103/

@alaxalves
Copy link
Member

I think I know what is going on here Kaustubh, I have fixed it on Rails 5.2.3 upgrade. Just reverting database.yml wont fix our problem. Remember that we have found out that we had been running Travis for production env? So this is kinda related, out test credentials are mismatched. I'll try some stuff here.

@alaxalves
Copy link
Member

@jywarren @sashadev-sky @kaustubh-nair Pushed this to unstable and fixed it both on Travis and Jenkins. :D

Jenkins at: https://jenkins.laboratoriopublico.org/job/Mapknitter-Unstable/109/console
Travis at: https://travis-ci.org/publiclab/mapknitter/builds/550805436?utm_source=github_status&utm_medium=notification

@jywarren
Copy link
Member

jywarren commented Jun 27, 2019 via email

@jywarren
Copy link
Member

Ah i see you commented in Gitter. Merging then! Thanks!!

@jywarren jywarren merged commit 25681c7 into main Jun 27, 2019
@alaxalves alaxalves deleted the kaustubh-nair-patch-3 branch June 27, 2019 12:42
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
* Fix database.yml for test environment for unstable

* Update database.yml.example

* Revert database.yml

* Update database.yml.example

* Using correct config for database.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants