Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test asset compilation on travis #748

Closed
wants to merge 8 commits into from
Closed

Conversation

kaustubh-nair
Copy link
Member

Checking if rake assets:precompile works correctly on travis since we've switched to Rails 4

@codeclimate
Copy link

codeclimate bot commented Jun 26, 2019

Code Climate has analyzed commit da8a0ec and detected 0 issues on this pull request.

View more on Code Climate.

@kaustubh-nair
Copy link
Member Author

Hey @alaxalves, there's a problem with the production environment here. Can you have a look?
Thanks

@alaxalves
Copy link
Member

Hey @alaxalves, there's a problem with the production environment here. Can you have a look?
Thanks

#725 Solves it.

@kaustubh-nair
Copy link
Member Author

Hey @alaxalves, there's a problem with the production environment here. Can you have a look?
Thanks

#725 Solves it.

Okay let me try push those commits here

@kaustubh-nair
Copy link
Member Author

The build is still failing @alaxalves
But I was thinking.. why do we need to test this on travis?
We'll be doing it on jenkins anyway right?

@alaxalves
Copy link
Member

The build is still failing @alaxalves
But I was thinking.. why do we need to test this on travis?
We'll be doing it on jenkins anyway right?

The issue now is related to the assets, not the builds, BTW this is going well on #685. I think is related to the newer Yarn setup and asset related gems upgrade.
I think it's necessary having this job, because it makes clearer and faster to identify when an asset is deprecated and such. But let's hear from @sashadev-sky too.

@alaxalves
Copy link
Member

The build is still failing @alaxalves
But I was thinking.. why do we need to test this on travis?
We'll be doing it on jenkins anyway right?

BTW the build is failing now because of the single asset job. It wasn't running any test previously.

@alaxalves
Copy link
Member

I don't this MR is needed since it's already fixed here -> #685

@kaustubh-nair
Copy link
Member Author

kaustubh-nair commented Jun 28, 2019 via email

@kaustubh-nair
Copy link
Member Author

Fixed in rails 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants