-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the extra space after share
#4611
Comments
On it! |
Fixes Issue : publiclab#4611
Fixes Issue publiclab#4611
Im claiming this issue. Has anyone else claimed it ? If you have have you created a pull request already ? If your stuck I guess I can help you. |
Hi @Gonnuru, a PR by @jaidev123 is already in progress at #4612 so please find another issue and seems like @jaidev123 is stuck with ruby version problem so you can surely help by coordinating with them in the PR. Thanks! |
I am taking up this issue. |
The issue already has PR, so please look for another issues to solve. You can explore FTO issues at https://code.publiclab.org/#r=all and if you can't find one there, feel free to comment here, we'll try to open one for you. Thanks! |
* Removed Extra Sprace after 'Share' Fixes Issue : #4611 * Update rich.html.erb
* Removed Extra Sprace after 'Share' Fixes Issue : publiclab#4611 * Update rich.html.erb
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file
app/views/editor/rich.html.erb
in theplots2
repository (press the little pen Icon) and edit the line as shown below.plots2/app/views/editor/rich.html.erb
Lines 30 to 37 in 87db564
Remove the extra space which is below the
share
button text.See this page for some help in taking your first steps!
Below is a "diff" showing in red (and a
-
) which lines to remove, and in green (and a+
) which lines to add:💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
The text was updated successfully, but these errors were encountered: