Removed Extra Space after 'Share' #4612
Conversation
Fixes Issue : publiclab#4611
Generated by 🚫 Danger |
app/views/editor/rich.html.erb
Outdated
| @@ -29,8 +29,6 @@ | |||
|
|
|||
| <!-- errors module --> | |||
| <div class="ple-module container"> | |||
There was a problem hiding this comment.
- <div class="ple-module container">Remove this line too
There was a problem hiding this comment.
All right. Removing the closing div as well
app/views/editor/rich.html.erb
Outdated
| @@ -29,8 +29,6 @@ | |||
|
|
|||
| <!-- errors module --> | |||
| <div class="ple-module container"> | |||
|
|
|||
| <div class="col-md-3"></div> | |||
| <div class="ple-errors col-md-9"></div> | |||
There was a problem hiding this comment.
| <div class="ple-errors col-md-9"></div> | |
| <div class="ple-errors"></div> |
Do this..
|
Hi @jaidev123, welcome to Public Lab! Also, upload a screenshot of the feature working on your localhost |
oorjitchowdhary
changed the title
|
@publiclab/reviewers Hey! Currently, it seems like I have to create a new PR in order to add the suggested changes proposed by @oorjitchowdhary . Is there another way? (instead of closing this PR and then starting another one). Also, how can I run this on my PC? Thanks! |
|
Hey, you can still make changes in this PR. You opened this PR from the |
|
Hey! Looks like all checks have passed :) |
|
Hi @jaidev123, this looks great. We just require screenshots now. |
|
Seems to have hit a roadblock.
I've tried bundle install and bundle update with no progress. Tried rolling back ruby to 2.4 but error message states that I have to use 2.5 or later. Do you know of a fix for this? Could this be because patch-1 branch hasn't been updated in some time? |
|
Hi! Would you like to take a look at this page to see if you can get some
setup help? #3840
I think though that you may need to install Ruby 2.4.4. You could do this
using RVM -- http://rvm.io/
…On Thu, Jan 17, 2019 at 2:07 AM Jaidev Shriram ***@***.***> wrote:
Seems to have hit a roadblock.
[image: screenshot 4]
<https://user-images.githubusercontent.com/29925421/51301195-565cad00-1a54-11e9-8885-e6532765ba35.png>
I've tried bundle install and bundle update with no progress. Tried
rolling back ruby to 2.4 but error message states that I have to use 2.5 or
later. Do you know of a fix for this? Could this be because patch-1 branch
hasn't been updated in some time?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJw6yfO0x8VCx5ZIcaxbFtBszOLRwks5vECEfgaJpZM4Z9vej>
.
|
|
Hey. It looks like I'm going to be busy for a while. Could someone else please continue this? |
|
Hi @jaidev123, no issue. I will add the screenshot on your behalf and complete this PR. Thanks! |
|
Merged 🎉 🎈 ! Hi @jaidev123, thanks for the nice work. We would love to have more help from you. If you are interested in solving more issues then check here - https://code.publiclab.org/#r=all for a new issue. In case, you are unable to find an issue, feel free to comment here. Thanks! |
* Removed Extra Sprace after 'Share' Fixes Issue : publiclab#4611 * Update rich.html.erb
Fixes Issue : #4611
Fixes #4611(<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!