Dividing the tags page to make it two-column and add graph in second column #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
@jywarren @gauravano Can I have some insight regarding this as I need to make a new PR for stats graph in second column. But before that I need this PR to be required first. 😅 |
5 tasks
|
This looks awesome! Shall we try to add the |
CleverFool77
changed the title
|
@jywarren @gauravano I did as you suggested and added the second part of issue in this PR itself. |
jywarren
approved these changes
Mar 19, 2019
|
Adding |
|
Awesome!!! |
cesswairimu
pushed a commit
to cesswairimu/plots2
that referenced
this pull request
Mar 21, 2019
…column (publiclab#5100) * Dividing the tags page to make it two-column * add stats graph in second column
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
…column (publiclab#5100) * Dividing the tags page to make it two-column * add stats graph in second column
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
…column (publiclab#5100) * Dividing the tags page to make it two-column * add stats graph in second column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5090 first part and second part (<=== Add issue number here)
Description
For building the new tags page, the first step was to divide the tags page into two column.
And second was to add an iframe to second column.
rake test@publiclab/reviewersfor help, in a comment belowThanks!