Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new design for Tags page (needs breaking up) #5090

Closed
4 of 5 tasks
jywarren opened this issue Mar 15, 2019 · 46 comments · Fixed by #5384
Closed
4 of 5 tasks

Implement new design for Tags page (needs breaking up) #5090

jywarren opened this issue Mar 15, 2019 · 46 comments · Fixed by #5384
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML Ruby
Milestone
User interface (UI)

Comments

@jywarren
Copy link
Member

jywarren commented Mar 15, 2019 •
edited
Loading

Building on #4922, we should work to rebuild the page at https://publiclab.org/tags following this design:

Screen Shot 2019-03-15 at 12 45 20 PM

There's discussion about this here: https://publiclab.org/notes/edie_blues/01-09-2019/the-tags-page-mockup-let-me-know-what-you-think#c22154

The current template is here: https://github.com/publiclab/plots2/tree/master/app/views/tag/index.html.erb

Steps that could be broken out include:

I'd love help with this one!
@jywarren jywarren added help wanted requires help by anyone willing to contribute Ruby design issue requires more design work and discussion (i.e. mockups and sketches) break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration HTML labels Mar 15, 2019
@jywarren jywarren added this to the User interface (UI) milestone Mar 15, 2019
@jywarren jywarren mentioned this issue Mar 15, 2019
Merged
5 tasks
@CleverFool77
Copy link
Member

CleverFool77 commented Mar 15, 2019 •
edited
Loading

@jywarren I would love to work on this issue. Can I start with the first part of making it two-column.

@jywarren
Copy link
Member Author

jywarren commented Mar 15, 2019 via email

@divyabaid16
Copy link
Contributor

@jywarren Should I work on redesigning the search bar?

@jywarren
Copy link
Member Author

jywarren commented Mar 15, 2019 via email

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 16, 2019 •
edited
Loading

@jywarren Is this what the first part says ? I've opened a PR dividing it into two parts.
Screenshot from 2019-03-16 10-11-38

@CleverFool77 CleverFool77 mentioned this issue Mar 16, 2019
Merged
5 tasks
@CleverFool77
Copy link
Member

@jywarren Is it possible for a same person to work on other parts too ?
If yes, then I would like to go for second part too. :)

@IshaGupta18
Copy link
Collaborator

@CleverFool77 I would like to help out here! Let me know if you are stuck anywhere, we can work it out together!

@divyabaid16 divyabaid16 mentioned this issue Mar 17, 2019
Merged
5 tasks
@CleverFool77
Copy link
Member

I'll ask you for sure @IshaGupta18 :)

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 17, 2019 •
edited
Loading

Hi @IshaGupta18,
I was working on the part of showing iframe. So should I write the code again along with ajax or should I show the graph generated in graph.html here. I'm haven't used ruby on rails on fully-fledged project yet. So still learning regarding this.

@jywarren
Copy link
Member Author

jywarren commented Mar 18, 2019 via email

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 18, 2019 •
edited
Loading

@jywarren Something like this -
Screenshot from 2019-03-18 23-57-57

I haven't given margin yet. And the tags graph is not getting cut rather I zoomed it as it was not visible because I had 3-4 different small graph. So for now I zoomed it

@gautamig54
Copy link
Contributor

Can I be of any help here? It would be great if I can contribute! Thanks

@CleverFool77
Copy link
Member

@jywarren @gauravano Can we have first PR merged first because I guess all other changes will be dependent on first. PR link
@gautamig54 You can start with any of the part of this issue. But now the further parts will be dependent on each other I guess. 🤔

@CleverFool77
Copy link
Member

@gautamig54 Right now, I'm working on stats graph PR to be shown in second column. If you are interested you can go for third part 😉

@gautamig54
Copy link
Contributor

@CleverFool77 Okay! I'll start with the 3rd one! Thanks!

@divyabaid16
Copy link
Contributor

Should I complete the last task? Can I start with that part?
Thanks!

@jywarren
Copy link
Member Author

Oops didn't mean to close the whole thing! Re-opening now - and thank you for collaborating!

@jywarren jywarren reopened this Mar 18, 2019
@jywarren
Copy link
Member Author

Oh, oops, ok - so, i see, there's a sequence. It looks like @CleverFool77 has already started #5100 and could we finish up the iframe stuff there before merging it (typically 2 PRs would be great, but these are so tied to one another -- it didn't make sense to me to merge the first one and then publish a page which is halfway empty, you know?) so then we can get the basic page merged at once, then we can move on to the next few? Thanks everyone, this is cool!

@jywarren
Copy link
Member Author

If we want to add a new item which is 'zooming the tags graph' i think it's possible perhaps using this documentation: http://js.cytoscape.org/

and this code? -- https://github.com/publiclab/plots2/blob/master/app/views/tag/graph.html.erb

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 19, 2019 •
edited
Loading

Hi @jywarren I found the fix to be done in featured part of this issue. But you mentioned in issue #5004 that this is stored in database. Then can i have some insight on this ?

@jywarren jywarren reopened this Mar 19, 2019
@jywarren
Copy link
Member Author

Merged #5100! Now on to next steps; perhaps #5172 is next?

@jywarren
Copy link
Member Author

I see progress at #5169 as well on a card layout!

@jywarren
Copy link
Member Author

Let's make sure the card layout by @CleverFool77 is compatible with the sorting in #5176 by @divyabaid16 ! What amazing multiperson cooperation here!!! 🙌

@CleverFool77
Copy link
Member

Hi @jywarren The basic card layout is for people's section. Regarding the basic card layout in tags section, I guess @divyabaid16 is working it as she already mentioned. She did great work in sort section,so if the same person is doing the both the work then compatibility will be checked easily.

Later, the UI will be improved from basic structure with collaboration between various contributors.
Thanks !!!

@CleverFool77
Copy link
Member

Hi @gautamig54, Do you need any help ?

@gautamig54
Copy link
Contributor

@CleverFool77 Thanks! I am working on the 3rd task. I'll surely ask for help if need be 👍

@divyabaid16
Copy link
Contributor

I'm actually confused whether to send the PR for the card ui or not. Because it's a carrier forward of my previous 2 PRs.

@gautamig54 gautamig54 mentioned this issue Mar 20, 2019
Merged
5 tasks
@gautamig54
Copy link
Contributor

@jywarren @CleverFool77 I have done the 3rd task and have submitted a PR for the same. Pl review it.

@gautamig54
Copy link
Contributor

On the tags page, the number of tags shown on the left are more in number which results in empty space on the right, below the graph. I think some amendments should be done regarding this in the design. What say @jywarren @CleverFool77?

Screen Shot 2019-03-21 at 7 58 16 PM

@CleverFool77
Copy link
Member

HI @divyabaid16 I wanted to ask which two previous PR. Isn't it one PR which is for sort ?

@CleverFool77
Copy link
Member

Oh I see it now regarding what you mean about 2 PRs, @divyabaid16. I guess we need to wait. 🤔
@gautamig54 Lets see what's there in new UI for this.

@gautamig54
Copy link
Contributor

@CleverFool77 Featured topics have not been added to the new UI design?

@CleverFool77
Copy link
Member

@gautmig54 Yes it has not been added yet. I asked @jywarren about this question in these comments above.
Thanks :)

@jywarren jywarren reopened this Mar 22, 2019
@jywarren
Copy link
Member Author

Ah, sorry, responding now:

Hi @jywarren I found the fix to be done in featured part of this issue. But you mentioned in issue #5004 that this is stored in database. Then can i have some insight on this ?

Yes, I think we are OK on this now: https://publiclab.org/tags

Although we should rename the page simply "Tags" and perhaps we can remove the text (i can copy it into the database so we can change it more easily instead of tracking it in the codebase!)

@jywarren
Copy link
Member Author

One thing is that the table headings are a bit crowded - i guess we'll be removing them when we make cards, though?

image

Looking at #5176 now for the sorting, then ready to move on to card display! (@CleverFool77 i saw your note on people page card design, you're totally right, thanks!)

@divyabaid16 divyabaid16 mentioned this issue Mar 24, 2019
Merged
5 tasks
@jywarren jywarren mentioned this issue Mar 25, 2019
Closed
@jywarren jywarren reopened this Apr 5, 2019
@jywarren
Copy link
Member Author

jywarren commented Apr 5, 2019

#5239 complete - now just the card UI!

@divyabaid16
Copy link
Contributor

I will send the PR for this part by today.
Thanks!

@divyabaid16 divyabaid16 mentioned this issue Apr 6, 2019
Merged
5 tasks
@divyabaid16 divyabaid16 mentioned this issue Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML Ruby
Projects
None yet
Milestone
User interface (UI)
Development

Successfully merging a pull request may close this issue.

Redesigned table to use card ui in tags page divyabaid16/plots2
5 participants
@jywarren @CleverFool77 @divyabaid16 @gautamig54 @IshaGupta18