Adding the links below the graph for Tags page #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
The image looks so close to the aim.. 😍 |
|
@jywarren Kindly look into the PR and merge if all seem fine. Thanks! |
grvsachdeva
reviewed
Mar 21, 2019
app/views/tag/index.html.erb
Outdated
| <a style="cursor: pointer;" onclick="document.getElementById('myImage').src='stats/graph.html?limit=100'"><u>100</u></a> | | ||
| <a style="cursor: pointer;" onclick="document.getElementById('myImage').src='stats/graph.html?limit=250'"><u>250</u></a> | | ||
| <a style="cursor: pointer;" onclick="document.getElementById('myImage').src='stats/graph.html?limit=500'"><u>500</u></a> | ||
| </h6> |
There was a problem hiding this comment.
wow this is such a clever solution! Thank you!
There was a problem hiding this comment.
Thank you @jywarren @gauravano!
grvsachdeva
reviewed
Mar 21, 2019
|
@gauravano sure i'll do it. Thanks! |
|
If it's possible to highlight the link and you can share a screenshot of that working, we're happy to merge this, thanks! |
|
Okay @jywarren. I'll highlight the active link and make a PR. Should I make a different PR or push commit here? |
|
@jywarren @gauravano I have implemented highlighting the active link and pushed commit to this PR. Kindly look into it. Thanks!
|
|
This is so nice!!! I'm merging now. Great work! |
|
Thanks @jywarren |
|
Ok, done! Thanks!
…On Thu, Mar 21, 2019, 4:45 PM Gautami Gupta ***@***.***> wrote:
Thanks @jywarren <https://github.com/jywarren>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5209 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ2LRaLKjEVIdd3OhLEQJpLkf2Wa8ks5vY-86gaJpZM4cAT_g>
.
|
jywarren
pushed a commit
that referenced
this pull request
Mar 29, 2019
* add_links_below_graphs * add_links_below_graphs2 * highlighting the active link
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* add_links_below_graphs * add_links_below_graphs2 * highlighting the active link
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* add_links_below_graphs * add_links_below_graphs2 * highlighting the active link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5090 (<=== Add issue number here)
Fixing the 3rd task of adding links below the graph for the new design of the tags page.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!