Redesigned table to use card ui in tags page

[divyabaid16]

Fixes #5090 (<=== Add issue number here)

Screenshot for the card ui:

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[plotsbot]

	1 Message
📖	@divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[ananyaarun]

Wow @divyabaid16 this is a really nice change :) !!

[divyabaid16]

Thank you @ananyaarun 😄
Can you please review this @jywarren ?

[jywarren]

This looks super! 🎉

I'd like to ask for a couple small tweaks - can we unbold the tag titles, and could we add a bit more padding to the bottom of each box?

Then this should be good to go, and we can do a follow-up with adding more stuff to each tag box, like a few recent posts for example.

Great work!!!

[jywarren]

Actually, would you like to try breaking this into its own partial, maybe called _topicCard.html.erb?

[divyabaid16]

@jywarren I have made the changes.
The updates screenshot:

Thanks!!

[jywarren]

This is looking awesome! It's still a little empty without the content in there. Would you like to try displaying the titles of three of the most recent posts in each topic, in a compact list, in the box? Or do you think we should merge this first and do it in a follow-up? Thank you!!!

[divyabaid16]

@jywarren I will try displaying the titles of three of the most recent posts in each topic. The PR was getting very long so I thought that I would do it in the next.
Thanks :)

[jywarren]

Thank you, usually i would agree! I just think we're almost there and they look a little empty right now. Thank you!!!

…

On Fri, Apr 19, 2019 at 2:13 AM Divya Baid ***@***.***> wrote: @jywarren <https://github.com/jywarren> I will try displaying the titles of three of the most recent posts in each topic. The PR was getting very long so I thought that I would do it in the next. Thanks :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5384 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4O7JORHGG6J7PWPM3PRFMFJANCNFSM4HEAXMEQ> .

[divyabaid16]

@jywarren I have tried displaying the titles of three of the most recent posts in each topic and this is how it looks now:

Please let me know if there is any further change.
Thanks!

[jywarren]

This is beautiful!!! It's perfect! Thank you so much!

[jywarren]

Great. I'm going to try publishing it now!!!

[divyabaid16]

@jywarren please do tag me if any other help is required as I won't be much available due to my exams.
Thanks!